[PR #470] [MERGED] Improve log legibility #891

New issue

Closed

opened 2026-10-31 22:17:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/470
Author: @webfiltered
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @huchenlei

Base: main ← Head: clean-logs

📝 Commits (3)

bd199c3 Improve log legibility
35608ac [Refactor] Simplify code, use log transforms
bee0e9a [Refactor] Use manual log transforms

📊 Changes

4 files changed (+15 additions, -10 deletions)

View changed files

📝 src/main-process/comfyDesktopApp.ts (+3 -3)
📝 src/main-process/comfyServer.ts (+7 -1)
📝 src/services/backup.ts (+3 -6)
📝 src/utils.ts (+2 -0)

📄 Description

Strips all escape codes from wrapped-process output logs.

From this:

[2024-12-12 23:55:59.116] [info]  [?25l[37m[H⠸ [m[2mResolving dependencies...                                                     [K[?25h[1;134H
[2024-12-12 23:55:59.135] [info]  [?25l[22m[1;80H[?25h
[2024-12-12 23:55:59.309] [info]  [?25l[37m[H⠸ [m[2maiohappyeyeballs==2.4.3                                                       [K[?25h[1;136H
[2024-12-12 23:55:59.328] [info]  [?25l[22m[37m[H⠼ [m[2maiohappyeyeballs==2.4.3                                                       [K[?25h[1;136H

To this:

[2024-12-12 23:55:59.116] [info]  ⠸ Resolving dependencies...                                                     
[2024-12-12 23:55:59.135] [info]  
[2024-12-12 23:55:59.309] [info]  ⠸ aiohappyeyeballs==2.4.3                                                       
[2024-12-12 23:55:59.328] [info]  ⠼ aiohappyeyeballs==2.4.3

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/470 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `clean-logs` --- ### 📝 Commits (3) - [`bd199c3`](https://github.com/Comfy-Org/desktop/commit/bd199c39ed4c7522fd4616a7dc0496b9a05d18a8) Improve log legibility - [`35608ac`](https://github.com/Comfy-Org/desktop/commit/35608ac93b41518d4244b0dc3572a8165bea06de) [Refactor] Simplify code, use log transforms - [`bee0e9a`](https://github.com/Comfy-Org/desktop/commit/bee0e9a6a220059c4f294cac432551169db4913a) [Refactor] Use manual log transforms ### 📊 Changes **4 files changed** (+15 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/comfyDesktopApp.ts` (+3 -3) 📝 `src/main-process/comfyServer.ts` (+7 -1) 📝 `src/services/backup.ts` (+3 -6) 📝 `src/utils.ts` (+2 -0) </details> ### 📄 Description Strips all escape codes from wrapped-process output logs. #### From this: ```log [2024-12-12 23:55:59.116] [info] [?25l[37m[H⠸ [m[2mResolving dependencies... [K[?25h[1;134H [2024-12-12 23:55:59.135] [info] [?25l[22m[1;80H[?25h [2024-12-12 23:55:59.309] [info] [?25l[37m[H⠸ [m[2maiohappyeyeballs==2.4.3 [K[?25h[1;136H [2024-12-12 23:55:59.328] [info] [?25l[22m[37m[H⠼ [m[2maiohappyeyeballs==2.4.3 [K[?25h[1;136H ``` #### To this: ```log [2024-12-12 23:55:59.116] [info] ⠸ Resolving dependencies... [2024-12-12 23:55:59.135] [info] [2024-12-12 23:55:59.309] [info] ⠸ aiohappyeyeballs==2.4.3 [2024-12-12 23:55:59.328] [info] ⠼ aiohappyeyeballs==2.4.3 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:47 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#891

No description provided.

Rows
Columns