[PR #487] [MERGED] Fix log files not rotated #904

New issue

Closed

opened 2026-10-31 22:17:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/487
Author: @webfiltered
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @huchenlei

Base: main ← Head: fix-log-rotation

📝 Commits (1)

95dd35e Fix log files not rotated

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/utils.ts (+1 -1)

📄 Description

Regex escape codes need second escape due to use of string template (originally written as a regex literal).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/487 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix-log-rotation` --- ### 📝 Commits (1) - [`95dd35e`](https://github.com/Comfy-Org/desktop/commit/95dd35e9d9406229c52f62e5881582b1b15afa4d) Fix log files not rotated ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/utils.ts` (+1 -1) </details> ### 📄 Description Regex escape codes need second escape due to use of string template (originally written as a regex literal). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:55 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:16 +00:00

[PR #904] [MERGED] [Doc] Add code documentation #1193

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#904

No description provided.

Rows
Columns