[PR #539] [MERGED] Lint & refactor codebase #920

New issue

Closed

opened 2026-10-31 22:18:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/539
Author: @webfiltered
Created: 12/19/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @huchenlei

Base: main ← Head: make-clean

📝 Commits (10+)

59e2a6f Ignore shims script (hard forked)
649535d Format scripts
30d8e6f Remove redundant code
617e57a [Refactor] Remove ternary statement
5c67a14 Add ESM top-level await
c51ee3f Add TS types, clean up
fc93d52 Ignore ESLint warnings in scripts
0453b59 Remove redundant code
701fc4d Lint tests
f508a0e Remove stylistic ESLint rule

📊 Changes

33 files changed (+345 additions, -305 deletions)

View changed files

📝 .prettierignore (+1 -1)
📝 eslint.config.js (+11 -1)
📝 playwright.setup.ts (+7 -8)
📝 scripts/downloadFrontend.js (+35 -34)
📝 scripts/downloadUV.js (+61 -64)
📝 scripts/getPackage.js (+3 -2)
📝 scripts/launchdev.js (+1 -0)
📝 scripts/makeComfy.js (+4 -4)
📝 scripts/preMake.js (+37 -35)
📝 scripts/prepareTypes.js (+7 -13)
📝 scripts/releaseTypes.js (+18 -16)
📝 scripts/resetInstall.js (+19 -13)
📝 scripts/todesktop/afterPack.cjs (+23 -18)
📝 scripts/todesktop/beforeInstall.cjs (+23 -18)
📝 scripts/updateFrontend.js (+24 -20)
📝 src/config/comfyServerConfig.ts (+6 -2)
📝 src/config/comfySettings.ts (+2 -0)
📝 src/handlers/pathHandlers.ts (+3 -0)
📝 src/install/installWizard.ts (+5 -2)
📝 src/install/installationValidator.ts (+1 -1)

...and 13 more files

📄 Description

Requires #536
Adds top-level awaits to scripts
Annotates unfixed issues
Various minor refactors & linting
Formats loose scripts

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/539 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/19/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `make-clean` --- ### 📝 Commits (10+) - [`59e2a6f`](https://github.com/Comfy-Org/desktop/commit/59e2a6fb24cabbfb00b7e525202148f811e0fc63) Ignore shims script (hard forked) - [`649535d`](https://github.com/Comfy-Org/desktop/commit/649535df22445918ec8259ba0d1c942ce0886616) Format scripts - [`30d8e6f`](https://github.com/Comfy-Org/desktop/commit/30d8e6f8cc60d2dacf2ddfe701dd1c1825cc0705) Remove redundant code - [`617e57a`](https://github.com/Comfy-Org/desktop/commit/617e57a867e4baaa8706df8b4feba61ddcdbb1cc) [Refactor] Remove ternary statement - [`5c67a14`](https://github.com/Comfy-Org/desktop/commit/5c67a140d9014a4efa95e3f048d283e218a5ccf1) Add ESM top-level await - [`c51ee3f`](https://github.com/Comfy-Org/desktop/commit/c51ee3f47e321baca5bd32bbfd0138c8dc845927) Add TS types, clean up - [`fc93d52`](https://github.com/Comfy-Org/desktop/commit/fc93d52934006f8ff02d550be2dd9db9acfb19e1) Ignore ESLint warnings in scripts - [`0453b59`](https://github.com/Comfy-Org/desktop/commit/0453b59cbeb5739f7b5a8928967f9f73a6ce5dbf) Remove redundant code - [`701fc4d`](https://github.com/Comfy-Org/desktop/commit/701fc4d54a75848b089d0b329886ca6664e76e64) Lint tests - [`f508a0e`](https://github.com/Comfy-Org/desktop/commit/f508a0ea577afd967524b0963d1bb971add07a11) Remove stylistic ESLint rule ### 📊 Changes **33 files changed** (+345 additions, -305 deletions) <details> <summary>View changed files</summary> 📝 `.prettierignore` (+1 -1) 📝 `eslint.config.js` (+11 -1) 📝 `playwright.setup.ts` (+7 -8) 📝 `scripts/downloadFrontend.js` (+35 -34) 📝 `scripts/downloadUV.js` (+61 -64) 📝 `scripts/getPackage.js` (+3 -2) 📝 `scripts/launchdev.js` (+1 -0) 📝 `scripts/makeComfy.js` (+4 -4) 📝 `scripts/preMake.js` (+37 -35) 📝 `scripts/prepareTypes.js` (+7 -13) 📝 `scripts/releaseTypes.js` (+18 -16) 📝 `scripts/resetInstall.js` (+19 -13) 📝 `scripts/todesktop/afterPack.cjs` (+23 -18) 📝 `scripts/todesktop/beforeInstall.cjs` (+23 -18) 📝 `scripts/updateFrontend.js` (+24 -20) 📝 `src/config/comfyServerConfig.ts` (+6 -2) 📝 `src/config/comfySettings.ts` (+2 -0) 📝 `src/handlers/pathHandlers.ts` (+3 -0) 📝 `src/install/installWizard.ts` (+5 -2) 📝 `src/install/installationValidator.ts` (+1 -1) _...and 13 more files_ </details> ### 📄 Description - Requires #536 - Adds top-level awaits to scripts - Annotates unfixed issues - Various minor refactors & linting - Formats loose scripts ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-539-Lint-refactor-codebase-1616d73d365081878d4bc64cbc24a79f) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:25 +00:00

[PR #920] [MERGED] [CI] Skip workflows when changes are irrelevant #1206

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#920

No description provided.

Rows
Columns