[PR #543] [MERGED] Fix cannot install on macOS with certain zsh config #922

New issue

Closed

opened 2026-10-31 22:18:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/543
Author: @webfiltered
Created: 12/20/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @huchenlei

Base: main ← Head: fix-zsh

📝 Commits (1)

7fb3d0e Fix cannot install on macOS with certain zsh config

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/virtualEnvironment.ts (+1 -1)

📄 Description

zsh parses hyphen inside double-quoted arguments as a command argument, not a string.

Just use a different prefix.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/543 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/20/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix-zsh` --- ### 📝 Commits (1) - [`7fb3d0e`](https://github.com/Comfy-Org/desktop/commit/7fb3d0e4e0f20a776d5e76fac5721d3d123d371b) Fix cannot install on macOS with certain zsh config ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+1 -1) </details> ### 📄 Description `zsh` parses hyphen inside double-quoted arguments as a command argument, not a string. Just use a different prefix. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-543-Fix-cannot-install-on-macOS-with-certain-zsh-config-1626d73d36508111abe4c38db919c90d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:25 +00:00

[PR #922] [MERGED] [GitHub] Improve bug report template #1208

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#922

No description provided.

Rows
Columns