[PR #544] [MERGED] Fix dev server does not restart on save #923

New issue

Closed

opened 2026-10-31 22:18:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/544
Author: @webfiltered
Created: 12/20/2024
Status: ✅ Merged
Merged: 12/24/2024
Merged by: @huchenlei

Base: main ← Head: yarn-start

📝 Commits (6)

345f4e3 Partially revert a179d5c: vite 6 breaks watch mode
7b13030 Replace launchdev script with vite plugin
8bf5606 Convert launchdev.js script to playwright loader
b98d101 Rename for clarity: vite.config.ts
0c030e6 Remove redundant code
3124c81 Remove debug code

📊 Changes

11 files changed (+349 additions, -413 deletions)

View changed files

➖ forge.env.d.ts (+0 -30)
➕ infrastructure/viteElectronAppPlugin.ts (+35 -0)
📝 package.json (+4 -4)
📝 playwright.setup.ts (+1 -1)
➕ scripts/launchCI.js (+45 -0)
➖ scripts/launchdev.js (+0 -85)
📝 tsconfig.json (+8 -1)
📝 vite.base.config.ts (+1 -16)
📝 vite.config.ts (+10 -3)
📝 vitest.workspace.ts (+1 -1)
📝 yarn.lock (+244 -272)

📄 Description

Requires #540
Renames vite.main.config.ts to vite.config.ts + update refs
Converts launchdev.js to launchCI.js - now builds and loads an instance for CI tests only
Dev watch/rebuild now uses built-in vite build --watch
Regular build mode unaffected
- Ignores assets and venv

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/544 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/20/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `yarn-start` --- ### 📝 Commits (6) - [`345f4e3`](https://github.com/Comfy-Org/desktop/commit/345f4e3675c4d4c88a289257aa2359a6dc5d6816) Partially revert a179d5c: vite 6 breaks watch mode - [`7b13030`](https://github.com/Comfy-Org/desktop/commit/7b13030983b7aba2be4dfa506840e1fd23d5eca8) Replace launchdev script with vite plugin - [`8bf5606`](https://github.com/Comfy-Org/desktop/commit/8bf5606e5010b3f09af190e560cfc8fe1070cf6e) Convert launchdev.js script to playwright loader - [`b98d101`](https://github.com/Comfy-Org/desktop/commit/b98d101da98c1825e7102697703ddc3236965ac0) Rename for clarity: vite.config.ts - [`0c030e6`](https://github.com/Comfy-Org/desktop/commit/0c030e6757b7e3d5775aaf0629e4c3f79018dfa1) Remove redundant code - [`3124c81`](https://github.com/Comfy-Org/desktop/commit/3124c81f6ea02362fbb5b132f4de3a40d4b5159f) Remove debug code ### 📊 Changes **11 files changed** (+349 additions, -413 deletions) <details> <summary>View changed files</summary> ➖ `forge.env.d.ts` (+0 -30) ➕ `infrastructure/viteElectronAppPlugin.ts` (+35 -0) 📝 `package.json` (+4 -4) 📝 `playwright.setup.ts` (+1 -1) ➕ `scripts/launchCI.js` (+45 -0) ➖ `scripts/launchdev.js` (+0 -85) 📝 `tsconfig.json` (+8 -1) 📝 `vite.base.config.ts` (+1 -16) 📝 `vite.config.ts` (+10 -3) 📝 `vitest.workspace.ts` (+1 -1) 📝 `yarn.lock` (+244 -272) </details> ### 📄 Description - Requires #540 - Renames `vite.main.config.ts` to `vite.config.ts` + update refs - Converts `launchdev.js` to `launchCI.js` - now builds and loads an instance for CI tests only - Dev watch/rebuild now uses built-in `vite build --watch` - Regular build mode unaffected - Ignores assets and venv ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-544-Fix-dev-server-does-not-restart-on-save-1626d73d36508112b65cfe653f13bab4) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:27 +00:00

[PR #923] [MERGED] [GitHub] Fix bug report formatting #1211

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#923

No description provided.

Rows
Columns