[PR #590] [MERGED] Update package: systeminformation - uses full PowerShell path #949

New issue

Closed

opened 2026-10-31 22:18:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/590
Author: @webfiltered
Created: 1/3/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @huchenlei

Base: main ← Head: fix-powershell-path

📝 Commits (2)

a70edd0 Update package: systeminformation - PowerShell PATH
a445b34 Fix cannot start ComfyUI: File not found

📊 Changes

3 files changed (+8 additions, -7 deletions)

View changed files

📝 package.json (+1 -1)
📝 src/shell/util.ts (+2 -1)
📝 yarn.lock (+5 -5)

📄 Description

Resolves root cause of #584
Implements fixes added in systeminformation (see https://github.com/sebhildebrandt/systeminformation/issues/957)
Resolves various issues caused at different installation states, when PowerShell is not in PATH
Forces standard env for all users - uses Windows PowerShell even if PS core is default

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/590 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix-powershell-path` --- ### 📝 Commits (2) - [`a70edd0`](https://github.com/Comfy-Org/desktop/commit/a70edd0ae65c498d255264293ff4373605dbef97) Update package: systeminformation - PowerShell PATH - [`a445b34`](https://github.com/Comfy-Org/desktop/commit/a445b3447741e70cde15f3f37bfcd2524092884d) Fix cannot start ComfyUI: File not found ### 📊 Changes **3 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -1) 📝 `src/shell/util.ts` (+2 -1) 📝 `yarn.lock` (+5 -5) </details> ### 📄 Description - Resolves root cause of #584 - Implements fixes added in `systeminformation` (see https://github.com/sebhildebrandt/systeminformation/issues/957) - Resolves various issues caused at different installation states, when PowerShell is not in PATH - Forces standard env for all users - uses Windows PowerShell even if PS core is default ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-590-Update-package-systeminformation-uses-full-PowerShell-path-1706d73d365081f6a8fbdb903a0b4b68) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:17 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#949

No description provided.

Rows
Columns