[PR #599] [MERGED] Fix exception on window style change #953

New issue

Closed

opened 2026-10-31 22:18:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/599
Author: @webfiltered
Created: 1/11/2025
Status: ✅ Merged
Merged: 1/12/2025
Merged by: @huchenlei

Base: main ← Head: fix-crash-on-change

📝 Commits (2)

8dcc508 Fix exception after change window style
f2dd023 nit

📊 Changes

1 file changed (+11 additions, -9 deletions)

View changed files

📝 src/main-process/appWindow.ts (+11 -9)

📄 Description

Guards against exception. Repro:

Change from default window style to custom via setWindowStyle
Send any window controls theme update (change button size / colour)
Throws

Solution

AppWindow now checks the settings it was created with, rather than the current settings.

Cause

Original frontend impl. was incomplete (settings), so the flaw went unnoticed.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/599 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/11/2025 **Status:** ✅ Merged **Merged:** 1/12/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix-crash-on-change` --- ### 📝 Commits (2) - [`8dcc508`](https://github.com/Comfy-Org/desktop/commit/8dcc50895c79d47fde6994349d0b0fc970dc7e44) Fix exception after change window style - [`f2dd023`](https://github.com/Comfy-Org/desktop/commit/f2dd023567800e0ddf8ec47e903ebb5725443015) nit ### 📊 Changes **1 file changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+11 -9) </details> ### 📄 Description Guards against exception. Repro: 1. Change from default window style to `custom` via `setWindowStyle` 2. Send any window controls theme update (change button size / colour) 3. Throws #### Solution AppWindow now checks the settings it was created with, rather than the current settings. #### Cause Original frontend impl. was incomplete (settings), so the flaw went unnoticed. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-599-Fix-exception-on-window-style-change-1786d73d36508128962ec734d4e7ab13) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:18 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:39 +00:00

[PR #953] [MERGED] [Test] Update expectation - increase timeout #1229

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#953

No description provided.

Rows
Columns