[PR #601] Window style change #954

New issue

Open

opened 2026-10-31 22:18:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/601
Author: @webfiltered
Created: 1/11/2025
Status: 🔄 Open

Base: main ← Head: window-style-change

📝 Commits (3)

59ed079 Allow change of window style without app restart
c104894 Add error handling & resilience to window style change
f90aaa3 nit

📊 Changes

2 files changed (+83 additions, -27 deletions)

View changed files

📝 src/handlers/appInfoHandlers.ts (+1 -1)
📝 src/main-process/appWindow.ts (+82 -26)

📄 Description

Based on #599
Requires https://github.com/Comfy-Org/ComfyUI_frontend/pull/2301
- Infinite loop caused by setting being updated when it has not changed
Requires #671
- Split from this PR

Current

When window style is changed in settings, the entire app and ComfyUI server must be restarted.
User can select no, which would require additional handling to clean up invalid state.

Proposed

Spawn a replacement window and load the original URL.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/601 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/11/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `window-style-change` --- ### 📝 Commits (3) - [`59ed079`](https://github.com/Comfy-Org/desktop/commit/59ed07956d1f37a30d2d9ea08e352a8945bc78ee) Allow change of window style without app restart - [`c104894`](https://github.com/Comfy-Org/desktop/commit/c1048944e003aad37850cec85137aea8e9dad613) Add error handling & resilience to window style change - [`f90aaa3`](https://github.com/Comfy-Org/desktop/commit/f90aaa3d7d10a2b74ac5e24f70fb7d3208b34ff5) nit ### 📊 Changes **2 files changed** (+83 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/appInfoHandlers.ts` (+1 -1) 📝 `src/main-process/appWindow.ts` (+82 -26) </details> ### 📄 Description - Based on #599 - Requires https://github.com/Comfy-Org/ComfyUI_frontend/pull/2301 - Infinite loop caused by setting being updated when it has not changed - Requires #671 - Split from this PR #### Current - When window style is changed in settings, the entire app and ComfyUI server must be restarted. - User can select no, which would require additional handling to clean up invalid state. #### Proposed - Spawn a replacement window and load the original URL. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-601-Window-style-change-1786d73d365081b58f01d3efa763deba) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 22:18:19 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#954

No description provided.

Rows
Columns