[PR #610] [MERGED] [Cleanup] Remove unnecessary async annotation #962

New issue

Closed

opened 2026-10-31 22:18:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/610
Author: @huchenlei
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @huchenlei

Base: main ← Head: unnecessary_async

📝 Commits (1)

3952f7c [Cleanup] Remove unnecessary async annotation

📊 Changes

2 files changed (+2 additions, -5 deletions)

View changed files

📝 src/handlers/pathHandlers.ts (+1 -2)
📝 src/main-process/comfyDesktopApp.ts (+1 -3)

📄 Description

Remove unnecessary async wrapping as nothing in the function body is async.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/610 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unnecessary_async` --- ### 📝 Commits (1) - [`3952f7c`](https://github.com/Comfy-Org/desktop/commit/3952f7c98a3bb5b7cc67478739c063dca2c2fcbd) [Cleanup] Remove unnecessary async annotation ### 📊 Changes **2 files changed** (+2 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/pathHandlers.ts` (+1 -2) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -3) </details> ### 📄 Description Remove unnecessary async wrapping as nothing in the function body is async. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-610-Cleanup-Remove-unnecessary-async-annotation-17b6d73d3650819faa9ce414c07af4b9) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:22 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:44 +00:00

[PR #962] [MERGED] Cherry-pick branch: Normalize paths in extra_model_paths #1239

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#962

No description provided.

Rows
Columns