[PR #615] [MERGED] Minor audit #967

New issue

Closed

opened 2026-10-31 22:18:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/615
Author: @webfiltered
Created: 1/14/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @webfiltered

Base: main ← Head: minor-audit

📝 Commits (5)

6f3e966 nit
56b6460 nit - Doc
48a1628 Fix incorrect CWD logged
7a396ec Remove workaround - device is always passed to desktop
761670d Do not log window close when quitting

📊 Changes

4 files changed (+9 additions, -5 deletions)

View changed files

📝 src/main.ts (+1 -0)
📝 src/preload.ts (+1 -1)
📝 src/virtualEnvironment.ts (+6 -3)
📝 tests/integration/startup.spec.ts (+1 -1)

📄 Description

Minor fixes

Fix incorrect CWD logged
Fix app quitting repeat logs
Fix TS type

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/615 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/14/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `minor-audit` --- ### 📝 Commits (5) - [`6f3e966`](https://github.com/Comfy-Org/desktop/commit/6f3e966648812d4af0beedff1fcd610e2dab992e) nit - [`56b6460`](https://github.com/Comfy-Org/desktop/commit/56b6460f4ab163dd7330e13d259231967c51a54e) nit - Doc - [`48a1628`](https://github.com/Comfy-Org/desktop/commit/48a16282efe73d420aa2f3a03476e4611e6152c5) Fix incorrect CWD logged - [`7a396ec`](https://github.com/Comfy-Org/desktop/commit/7a396ec93cbfa318fb5a6207dae021ad6ab24da9) Remove workaround - device is always passed to desktop - [`761670d`](https://github.com/Comfy-Org/desktop/commit/761670db724e107974955293a6e838eea8477a10) Do not log window close when quitting ### 📊 Changes **4 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+1 -0) 📝 `src/preload.ts` (+1 -1) 📝 `src/virtualEnvironment.ts` (+6 -3) 📝 `tests/integration/startup.spec.ts` (+1 -1) </details> ### 📄 Description #### Minor fixes - Fix incorrect CWD logged - Fix app quitting repeat logs - Fix TS type ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-615-Minor-audit-17b6d73d365081cda5eaddc8684fede3) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:24 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#967

No description provided.

Rows
Columns