[PR #641] [MERGED] [Refactor] Make ComfyDesktopApp own ComfyInstallation #984

New issue

Closed

opened 2026-10-31 22:18:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/641
Author: @huchenlei
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: own_install

📝 Commits (1)

1673d68 [Refactor] Make ComfyDesktopApp own ComfyInstallation

📊 Changes

2 files changed (+9 additions, -4 deletions)

View changed files

📝 src/main-process/comfyDesktopApp.ts (+8 -3)
📝 src/main.ts (+1 -1)

📄 Description

This PR is part of larger effort to sort out install time dependency issues.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/641 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `own_install` --- ### 📝 Commits (1) - [`1673d68`](https://github.com/Comfy-Org/desktop/commit/1673d68e90c2787e487a976ab0ba2de2ed41bdee) [Refactor] Make ComfyDesktopApp own ComfyInstallation ### 📊 Changes **2 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/comfyDesktopApp.ts` (+8 -3) 📝 `src/main.ts` (+1 -1) </details> ### 📄 Description This PR is part of larger effort to sort out install time dependency issues. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-641-Refactor-Make-ComfyDesktopApp-own-ComfyInstallation-17d6d73d3650811592daceca6af41ead) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:54 +00:00

[PR #984] [MERGED] [Test] Centralise common mocks #1260

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#984

No description provided.

Rows
Columns