[PR #647] [MERGED] Cleanup pre validation #990

New issue

Closed

opened 2026-10-31 22:18:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/647
Author: @webfiltered
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: cleanup-pre-validation

📝 Commits (5)

2fcb755 Remove redundant code
f91b12d Add logging
30907e1 Revert "[Refactor] Make ComfyDesktopApp own ComfyInstallation (#641)"
e530d91 [Refactor] Pass validated installation to ComfyDesktopApp
70b9a48 nit

📊 Changes

5 files changed (+16 additions, -10 deletions)

View changed files

📝 src/install/installationManager.ts (+3 -0)
📝 src/main-process/comfyDesktopApp.ts (+6 -8)
📝 src/main-process/comfyInstallation.ts (+3 -0)
📝 src/main.ts (+3 -1)
📝 src/store/desktopSettings.ts (+1 -1)

📄 Description

Fixes TS types
Adds logging
Replaces redundant static factory with constructor

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/647 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `cleanup-pre-validation` --- ### 📝 Commits (5) - [`2fcb755`](https://github.com/Comfy-Org/desktop/commit/2fcb755e6e3897e6c066b3c027080327b30dd210) Remove redundant code - [`f91b12d`](https://github.com/Comfy-Org/desktop/commit/f91b12d0a9394eaca66f5b1ffd1a58fa8eca3124) Add logging - [`30907e1`](https://github.com/Comfy-Org/desktop/commit/30907e1179f44bc6b55dac41a7657e4fca325382) Revert "[Refactor] Make ComfyDesktopApp own ComfyInstallation (#641)" - [`e530d91`](https://github.com/Comfy-Org/desktop/commit/e530d91a35d83f405ffe60f23b3a51e2f6e70f1f) [Refactor] Pass validated installation to ComfyDesktopApp - [`70b9a48`](https://github.com/Comfy-Org/desktop/commit/70b9a480caaea9de47558193a2447d9d0ae381e1) nit ### 📊 Changes **5 files changed** (+16 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+3 -0) 📝 `src/main-process/comfyDesktopApp.ts` (+6 -8) 📝 `src/main-process/comfyInstallation.ts` (+3 -0) 📝 `src/main.ts` (+3 -1) 📝 `src/store/desktopSettings.ts` (+1 -1) </details> ### 📄 Description - Fixes TS types - Adds logging - Replaces redundant static factory with constructor ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-647-Cleanup-pre-validation-17d6d73d36508143b705fd209048d12a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:35 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:57 +00:00

[PR #990] [CLOSED] text_encoders #1265

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#990

No description provided.

Rows
Columns