[PR #646] [MERGED] [chore] Upgrade typescript-eslint to v8 #991

New issue

Closed

opened 2026-10-31 22:18:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/646
Author: @huchenlei
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: fix_eslint_dep

📝 Commits (1)

83c217a [chore] Upgrade typescript-eslint to v8

📊 Changes

2 files changed (+98 additions, -140 deletions)

View changed files

📝 package.json (+2 -2)
📝 yarn.lock (+96 -138)

📄 Description

Get rid of eslint warning. The plugin deps were added in github.com/Comfy-Org/desktop@e8617b337d (5months ago), while the eslint itself is upgraded recently https://github.com/Comfy-Org/desktop/pull/536 (1months ago).

Before:

D:\desktop [main ≡]> yarn
➤ YN0000: · Yarn 4.5.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ eslint is listed by your project with version 9.17.0 (p3aad5), which doesn't satisfy what @typescript-eslint/eslint-plugin and other dependencies request (^8.57.0).
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 684ms
➤ YN0000: ┌ Link step
➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed
➤ YN0000: └ Completed in 2s 96ms
➤ YN0000: · Done with warnings in 3s 31ms

After:

D:\desktop [main ≡ +0 ~2 -0 !]> yarn
➤ YN0000: · Yarn 4.5.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 652ms
➤ YN0000: ┌ Link step
➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed
➤ YN0000: └ Completed in 1s 839ms
➤ YN0000: · Done with warnings in 2s 737ms

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/646 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_eslint_dep` --- ### 📝 Commits (1) - [`83c217a`](https://github.com/Comfy-Org/desktop/commit/83c217a576ff2e78836359aee3a1e2e8dce85d88) [chore] Upgrade typescript-eslint to v8 ### 📊 Changes **2 files changed** (+98 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -2) 📝 `yarn.lock` (+96 -138) </details> ### 📄 Description Get rid of eslint warning. The plugin deps were added in https://github.com/Comfy-Org/desktop/commit/e8617b337d8cc9796bc1de55be5a6b4c4be50fee (5months ago), while the eslint itself is upgraded recently https://github.com/Comfy-Org/desktop/pull/536 (1months ago). Before: ``` D:\desktop [main ≡]> yarn ➤ YN0000: · Yarn 4.5.0 ➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed ➤ YN0000: ┌ Post-resolution validation ➤ YN0060: │ eslint is listed by your project with version 9.17.0 (p3aad5), which doesn't satisfy what @typescript-eslint/eslint-plugin and other dependencies request (^8.57.0). ➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code. ➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details. ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ➤ YN0000: └ Completed in 0s 684ms ➤ YN0000: ┌ Link step ➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed ➤ YN0000: └ Completed in 2s 96ms ➤ YN0000: · Done with warnings in 3s 31ms ``` After: ``` D:\desktop [main ≡ +0 ~2 -0 !]> yarn ➤ YN0000: · Yarn 4.5.0 ➤ YN0000: ┌ Resolution step ➤ YN0000: └ Completed ➤ YN0000: ┌ Post-resolution validation ➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details. ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ➤ YN0000: └ Completed in 0s 652ms ➤ YN0000: ┌ Link step ➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed ➤ YN0000: └ Completed in 1s 839ms ➤ YN0000: · Done with warnings in 2s 737ms ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:35 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:56 +00:00

[PR #991] [MERGED] Update uv to latest patch version: 0.5.31 #1264

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#991

No description provided.

Rows
Columns