[PR #657] [MERGED] Add base path management API #998

New issue

Closed

opened 2026-10-31 22:18:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/657
Author: @webfiltered
Created: 1/17/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @huchenlei

Base: main ← Head: startup-ipc

📝 Commits (5)

0b22c6a Fix auto-rebase issue from refactor in #610
7e52b58 Allow base path retrieval at any point
dc8ae1a Add API to set the application base path
04e92db Fix manual demerge error - duplicate handler removed
3429933 Fix parameter missing from call sites

📊 Changes

6 files changed (+28 additions, -6 deletions)

View changed files

📝 src/constants.ts (+1 -0)
📝 src/handlers/appInfoHandlers.ts (+19 -1)
📝 src/main-process/comfyDesktopApp.ts (+0 -3)
📝 src/main.ts (+1 -1)
📝 src/preload.ts (+6 -0)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+1 -1)

📄 Description

Move the get base path to app info handler to make it available during the entire app lifecycle
- Previously required that ComfyDesktopApp was instantiated.
Add set base path, allowing change of the application path via API
- Frontend impl. will be added as part of startup validation

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/657 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/17/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `startup-ipc` --- ### 📝 Commits (5) - [`0b22c6a`](https://github.com/Comfy-Org/desktop/commit/0b22c6acd3f82c3830cd698f8168e0117c06d019) Fix auto-rebase issue from refactor in #610 - [`7e52b58`](https://github.com/Comfy-Org/desktop/commit/7e52b58d94d863ced6e57199e5aca7b7890e6c01) Allow base path retrieval at any point - [`dc8ae1a`](https://github.com/Comfy-Org/desktop/commit/dc8ae1a48963ded708bbac53f02735e44979170c) Add API to set the application base path - [`04e92db`](https://github.com/Comfy-Org/desktop/commit/04e92dbc0c905becbed3f66fa650b9b236258873) Fix manual demerge error - duplicate handler removed - [`3429933`](https://github.com/Comfy-Org/desktop/commit/3429933dce3a3357d8b865bd98e854ded06b0f95) Fix parameter missing from call sites ### 📊 Changes **6 files changed** (+28 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+1 -0) 📝 `src/handlers/appInfoHandlers.ts` (+19 -1) 📝 `src/main-process/comfyDesktopApp.ts` (+0 -3) 📝 `src/main.ts` (+1 -1) 📝 `src/preload.ts` (+6 -0) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+1 -1) </details> ### 📄 Description - Move the get base path to app info handler to make it available during the entire app lifecycle - Previously required that ComfyDesktopApp was instantiated. - Add set base path, allowing change of the application path via API - Frontend impl. will be added as part of startup validation ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-657-Add-base-path-management-API-17e6d73d3650810385c4f5b441fbbef0) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:59 +00:00

[PR #998] [MERGED] v0.4.21 #1272

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#998

No description provided.

Rows
Columns