[PR #192] [MERGED] fix: localize English range values in published-language node docs #193

Closed
opened 2026-10-26 22:10:30 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/embedded-docs/pull/192
Author: @lin-bot23
Created: 10/18/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @comfyui-wiki

Base: main ← Head: daily-docs-update-1019


📝 Commits (1)

  • 9cb5a66 fix: localize English range values in published-language node docs

📊 Changes

118 files changed (+326 additions, -326 deletions)

View changed files

📝 comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/ja.md (+2 -2)
📝 comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/ko.md (+2 -2)
📝 comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/zh-TW.md (+2 -2)
📝 comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/zh.md (+2 -2)
📝 comfyui_embedded_docs/docs/CosmosImageToVideoLatent/ja.md (+3 -3)
📝 comfyui_embedded_docs/docs/CosmosImageToVideoLatent/ko.md (+3 -3)
📝 comfyui_embedded_docs/docs/CosmosImageToVideoLatent/zh-TW.md (+3 -3)
📝 comfyui_embedded_docs/docs/CosmosImageToVideoLatent/zh.md (+3 -3)
📝 comfyui_embedded_docs/docs/CosmosPredict2ImageToVideoLatent/zh-TW.md (+3 -3)
📝 comfyui_embedded_docs/docs/CosmosPredict2ImageToVideoLatent/zh.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/ja.md (+2 -2)
📝 comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/zh-TW.md (+2 -2)
📝 comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/zh.md (+2 -2)
📝 comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/ja.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/ko.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/zh-TW.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyHunyuanImageLatent/ko.md (+2 -2)
📝 comfyui_embedded_docs/docs/EmptyLTXVLatentVideo/ko.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyLTXVLatentVideo/zh-TW.md (+3 -3)
📝 comfyui_embedded_docs/docs/EmptyMochiLatentVideo/ja.md (+3 -3)

...and 80 more files

📄 Description

Summary

Localized Range values that were still in English in the published node-doc languages (zh, zh-TW, ja, ko).

No new or changed nodes needed documentation today: the 3 nodes the scan reports as missing are nodes_replacements.py aliases, and all 72 "changed" nodes were verified as display-name / transport / execution-layer noise (see below).

What changed

  • 118 files, 326 Range cells, all inside zh.md / zh-TW.md / ja.md / ko.md
  • Two residue shapes:
    • fully English cells, e.g. 0.01 to 100.0, 0 to 18446744073709551615, 16 to MAX_RESOLUTION (step 16)
    • English connector with a partly localized or (step: N) suffix, e.g. 16 to MAX_RESOLUTION (step: 16), 16 to MAX_RESOLUTION (步长:16)
  • Wording is not newly translated: each language reuses the connector and step wording already used elsewhere in the same corpus (18 others-style sampling below)
language range connector step wording
zh N 到 M (步长:S)
zh-TW N 至 M (步進值:S)
ja N~M (ステップ S)
ko N ~ M (단계 S)

Identifiers stay English: MAX_RESOLUTION is untouched.

Verification

  • Script rewrites a cell only when its text is exactly the English cell, so it is idempotent (rerun: files=0 cells=0) and cannot damage already-localized cells
  • git diff --numstat: 326 insertions / 326 deletions, every file line-neutral
  • Table row count per file equals its en.md: 118/118 files match
  • Zero remaining | N to ... Range cells in zh/zh-TW/ja/ko
  • check_md_format.py --changed-only: 0 errors, 0 warnings
  • check_doc_structure.py --changed-only: 0 defects
  • check_md_links.py --changed-only: all local resource links valid
  • fix_translation_preamble.py --check-only: 0 leaked lines
  • No en.md touched, no non-.md file in the diff

Why the 72 "changed" nodes were skipped

review_changed_node_diffs.py (black-list diff of each node class between the footer-hash baseline and HEAD) plus a manual read of every remaining line:

  • display_name / category edits (#16274), search_aliases (ModelAttentionBackend), price-badge tables (11 Recraft nodes): not part of the doc body
  • transport / execution layer: Idempotency-Key (#16220), fast disk detection (#16425), torchaudio removal (#16457), UI.Saved3DModels output plumbing (Preview3DAdvanced, PreviewGaussianSplat, PreviewPointCloud, SaveGLB), EXR scene-linear conversion (SaveImageAdvanced), qem_simplify signature (DecimateMesh), webcam load_image fix (#17144), <think> partition fix (TextGenerate), asset_urls and retry handling
  • Flux3ImageNode: only the schema description string gained "Image"; the page's five price figures still match the current price_badge expression exactly

Not in this PR

  • The same residue in the unpublished languages is a much larger backlog (1,054 further cells across 227 nodes, de/he/it included), routed to a separate pass
  • Remaining English step words in cells where the connector is already localized are a distinct set and are left for that same pass

Review notes

CodeRabbit declined to review this PR ("Review limit reached", 118 billable files), so the checks in Verification were run locally on this branch after the commit. All four repository gates pass.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/embedded-docs/pull/192 **Author:** [@lin-bot23](https://github.com/lin-bot23) **Created:** 10/18/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@comfyui-wiki](https://github.com/comfyui-wiki) **Base:** `main` ← **Head:** `daily-docs-update-1019` --- ### 📝 Commits (1) - [`9cb5a66`](https://github.com/Comfy-Org/embedded-docs/commit/9cb5a664e30f38ab0e93037a013d639fcd076926) fix: localize English range values in published-language node docs ### 📊 Changes **118 files changed** (+326 additions, -326 deletions) <details> <summary>View changed files</summary> 📝 `comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/ja.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/ko.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/zh-TW.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/CLIPTextEncodePixArtAlpha/zh.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/CosmosImageToVideoLatent/ja.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/CosmosImageToVideoLatent/ko.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/CosmosImageToVideoLatent/zh-TW.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/CosmosImageToVideoLatent/zh.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/CosmosPredict2ImageToVideoLatent/zh-TW.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/CosmosPredict2ImageToVideoLatent/zh.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/ja.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/zh-TW.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/EmptyChromaRadianceLatentImage/zh.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/ja.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/ko.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyCosmosLatentVideo/zh-TW.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyHunyuanImageLatent/ko.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/EmptyLTXVLatentVideo/ko.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyLTXVLatentVideo/zh-TW.md` (+3 -3) 📝 `comfyui_embedded_docs/docs/EmptyMochiLatentVideo/ja.md` (+3 -3) _...and 80 more files_ </details> ### 📄 Description ## Summary Localized Range values that were still in English in the published node-doc languages (`zh`, `zh-TW`, `ja`, `ko`). No new or changed nodes needed documentation today: the 3 nodes the scan reports as missing are `nodes_replacements.py` aliases, and all 72 "changed" nodes were verified as display-name / transport / execution-layer noise (see below). ## What changed - 118 files, 326 Range cells, all inside `zh.md` / `zh-TW.md` / `ja.md` / `ko.md` - Two residue shapes: - fully English cells, e.g. `0.01 to 100.0`, `0 to 18446744073709551615`, `16 to MAX_RESOLUTION (step 16)` - English connector with a partly localized or `(step: N)` suffix, e.g. `16 to MAX_RESOLUTION (step: 16)`, `16 to MAX_RESOLUTION (步长:16)` - Wording is not newly translated: each language reuses the connector and step wording already used elsewhere in the same corpus (`18 others`-style sampling below) | language | range connector | step wording | | --- | --- | --- | | zh | `N 到 M` | `(步长:S)` | | zh-TW | `N 至 M` | `(步進值:S)` | | ja | `N~M` | `(ステップ S)` | | ko | `N ~ M` | `(단계 S)` | Identifiers stay English: `MAX_RESOLUTION` is untouched. ## Verification - Script rewrites a cell only when its text is exactly the English cell, so it is idempotent (rerun: `files=0 cells=0`) and cannot damage already-localized cells - `git diff --numstat`: 326 insertions / 326 deletions, every file line-neutral - Table row count per file equals its `en.md`: 118/118 files match - Zero remaining `| N to ...` Range cells in `zh`/`zh-TW`/`ja`/`ko` - `check_md_format.py --changed-only`: 0 errors, 0 warnings - `check_doc_structure.py --changed-only`: 0 defects - `check_md_links.py --changed-only`: all local resource links valid - `fix_translation_preamble.py --check-only`: 0 leaked lines - No `en.md` touched, no non-`.md` file in the diff ## Why the 72 "changed" nodes were skipped `review_changed_node_diffs.py` (black-list diff of each node class between the footer-hash baseline and HEAD) plus a manual read of every remaining line: - `display_name` / `category` edits (#16274), `search_aliases` (`ModelAttentionBackend`), price-badge tables (11 Recraft nodes): not part of the doc body - transport / execution layer: `Idempotency-Key` (#16220), fast disk detection (#16425), torchaudio removal (#16457), `UI.Saved3DModels` output plumbing (`Preview3DAdvanced`, `PreviewGaussianSplat`, `PreviewPointCloud`, `SaveGLB`), EXR scene-linear conversion (`SaveImageAdvanced`), `qem_simplify` signature (`DecimateMesh`), webcam `load_image` fix (#17144), `<think>` partition fix (`TextGenerate`), `asset_urls` and retry handling - `Flux3ImageNode`: only the schema `description` string gained "Image"; the page's five price figures still match the current `price_badge` expression exactly ## Not in this PR - The same residue in the unpublished languages is a much larger backlog (1,054 further cells across 227 nodes, `de`/`he`/`it` included), routed to a separate pass - Remaining English step words in cells where the connector is already localized are a distinct set and are left for that same pass ## Review notes CodeRabbit declined to review this PR ("Review limit reached", 118 billable files), so the checks in **Verification** were run locally on this branch after the commit. All four repository gates pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:10:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/embedded-docs#193
No description provided.