[PR #204] [MERGED] docs-generation: sync the Spanish locale to comfy/docs #202

New issue

Closed

opened 2026-10-26 22:10:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:10:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/embedded-docs/pull/204
Author: @lin-bot23
Created: 10/25/2026
Status: ✅ Merged
Merged: 10/25/2026
Merged by: @comfyui-wiki

Base: main ← Head: docs/es-locale-sync

📝 Commits (1)

cd04c44 docs-generation: sync the Spanish locale to comfy/docs

📊 Changes

1 file changed (+49 additions, -31 deletions)

View changed files

📝 docs-generation/scripts/sync_to_comfy_docs.py (+49 -31)

📄 Description

Adds the Spanish locale to the docs sync so comfyui_embedded_docs/docs/<Node>/es.md reaches docs.comfy.org.

Español is now a locale of the docs site (#2070, #2103), and every node already ships es.md upstream: 1022 of 1022 nodes have one. The sync tool itself still only knew en/zh/ja/ko, so the Spanish files had no path into the docs repository.

Changes

BUILTIN_ES target plus a fifth LOCALE_CONFIGS entry (es.md → es/built-in-nodes, tab Nodos integrados, wrapper Nodos, default group Avanzado).
Every CATEGORY_TO_GROUP tuple gains its Spanish label (28 categories: Acondicionamiento, Cargadores, Imagen, Latente, Muestreo, Avanzado, Utilidades, Nodo API, Parches de modelo, Lógica, Máscara, ...), and _default_group_for_lang takes the new index so an unmapped category lands in Avanzado instead of falling back to English.
Docstrings updated for the new locale.

Notes for reviewers

Nothing is generated by this PR. The docs repository keeps its own translate-i18n.ts --sync-docs-json --lang es for docs.json (it prunes pages that do not exist yet and translates the group labels), so pages can be synced with --no-docs-json and the nav follows automatically.
Verified with a trial run against a docs checkout: --mode test --count 3 --no-docs-json writes only es/built-in-nodes/*.mdx, leaving en/zh/ja/ko byte-identical.
pytest docs-generation/tests is 110 passed, 1 failed: test_translation_fixes.py::DryRunTests::test_persian_outputs_section_detected fails on origin/main as well (verified with git stash), so it is pre-existing.
Known upstream issue, not introduced here and not specific to Spanish: the first input-slot name in the parameters table is translated in roughly half of the localized docs (model → modelo, conditioning → acondicionamiento). Sampling 40 nodes gives zh 25/40, ja 23/40, ko 21/40, es 23/40, de 0/40. Slot names are UI/API identifiers, so this deserves its own fix across locales rather than being caught by the Spanish sync.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/embedded-docs/pull/204 **Author:** [@lin-bot23](https://github.com/lin-bot23) **Created:** 10/25/2026 **Status:** ✅ Merged **Merged:** 10/25/2026 **Merged by:** [@comfyui-wiki](https://github.com/comfyui-wiki) **Base:** `main` ← **Head:** `docs/es-locale-sync` --- ### 📝 Commits (1) - [`cd04c44`](https://github.com/Comfy-Org/embedded-docs/commit/cd04c44fca7be7b8d2f9f7dcfb73115475204af4) docs-generation: sync the Spanish locale to comfy/docs ### 📊 Changes **1 file changed** (+49 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `docs-generation/scripts/sync_to_comfy_docs.py` (+49 -31) </details> ### 📄 Description Adds the Spanish locale to the docs sync so `comfyui_embedded_docs/docs/<Node>/es.md` reaches docs.comfy.org. Español is now a locale of the docs site (#2070, #2103), and every node already ships `es.md` upstream: **1022 of 1022 nodes** have one. The sync tool itself still only knew `en`/`zh`/`ja`/`ko`, so the Spanish files had no path into the docs repository. **Changes** - `BUILTIN_ES` target plus a fifth `LOCALE_CONFIGS` entry (`es.md` → `es/built-in-nodes`, tab `Nodos integrados`, wrapper `Nodos`, default group `Avanzado`). - Every `CATEGORY_TO_GROUP` tuple gains its Spanish label (28 categories: `Acondicionamiento`, `Cargadores`, `Imagen`, `Latente`, `Muestreo`, `Avanzado`, `Utilidades`, `Nodo API`, `Parches de modelo`, `Lógica`, `Máscara`, ...), and `_default_group_for_lang` takes the new index so an unmapped category lands in `Avanzado` instead of falling back to English. - Docstrings updated for the new locale. **Notes for reviewers** - Nothing is generated by this PR. The docs repository keeps its own `translate-i18n.ts --sync-docs-json --lang es` for `docs.json` (it prunes pages that do not exist yet and translates the group labels), so pages can be synced with `--no-docs-json` and the nav follows automatically. - Verified with a trial run against a docs checkout: `--mode test --count 3 --no-docs-json` writes only `es/built-in-nodes/*.mdx`, leaving `en`/`zh`/`ja`/`ko` byte-identical. - `pytest docs-generation/tests` is 110 passed, 1 failed: `test_translation_fixes.py::DryRunTests::test_persian_outputs_section_detected` fails on `origin/main` as well (verified with `git stash`), so it is pre-existing. - Known upstream issue, not introduced here and not specific to Spanish: the first input-slot name in the parameters table is translated in roughly half of the localized docs (`model` → `modelo`, `conditioning` → `acondicionamiento`). Sampling 40 nodes gives zh 25/40, ja 23/40, ko 21/40, es 23/40, de 0/40. Slot names are UI/API identifiers, so this deserves its own fix across locales rather than being caught by the Spanish sync. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:10:42 +00:00