[PR #206] [MERGED] docs-generation: use the frontend display name for English node pages too #207

New issue

Closed

opened 2026-10-26 22:10:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:10:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/embedded-docs/pull/206
Author: @lin-bot23
Created: 10/25/2026
Status: ✅ Merged
Merged: 10/25/2026
Merged by: @comfyui-wiki

Base: main ← Head: docs/node-titles-en

📝 Commits (1)

77d5d8d docs-generation: use the frontend display name for English node pages too

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 docs-generation/scripts/sync_to_comfy_docs.py (+0 -2)

📄 Description

Follow-up to #205, which localized sidebarTitle and the title prefix for zh/ja/ko/es but returned early for en:

title: "ByteDance2TextToVideoNode - ComfyUI Built-in Node Documentation"
sidebarTitle: "ByteDance2TextToVideoNode"

The frontend labels that node ByteDance Seedance 2.5 Text to Video in en/nodeDefs.json, so the English pages were the only ones still showing the API type. Removing the early return makes English read from the same source as the other locales, with the same fallback to the node type when the frontend has no display_name.

Verified with --node ByteDance2TextToVideoNode, which now writes:

title: "ByteDance Seedance 2.5 Text to Video - ComfyUI Built-in Node Documentation"
sidebarTitle: "ByteDance Seedance 2.5 Text to Video"

Without this, the next full sync would revert the English titles that Comfy-Org/docs#2107 sets.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/embedded-docs/pull/206 **Author:** [@lin-bot23](https://github.com/lin-bot23) **Created:** 10/25/2026 **Status:** ✅ Merged **Merged:** 10/25/2026 **Merged by:** [@comfyui-wiki](https://github.com/comfyui-wiki) **Base:** `main` ← **Head:** `docs/node-titles-en` --- ### 📝 Commits (1) - [`77d5d8d`](https://github.com/Comfy-Org/embedded-docs/commit/77d5d8dc7a09d9224bcfd29b310363f1a0d54378) docs-generation: use the frontend display name for English node pages too ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs-generation/scripts/sync_to_comfy_docs.py` (+0 -2) </details> ### 📄 Description Follow-up to #205, which localized `sidebarTitle` and the `title` prefix for zh/ja/ko/es but returned early for `en`: ``` title: "ByteDance2TextToVideoNode - ComfyUI Built-in Node Documentation" sidebarTitle: "ByteDance2TextToVideoNode" ``` The frontend labels that node **ByteDance Seedance 2.5 Text to Video** in `en/nodeDefs.json`, so the English pages were the only ones still showing the API type. Removing the early return makes English read from the same source as the other locales, with the same fallback to the node type when the frontend has no `display_name`. Verified with `--node ByteDance2TextToVideoNode`, which now writes: ``` title: "ByteDance Seedance 2.5 Text to Video - ComfyUI Built-in Node Documentation" sidebarTitle: "ByteDance Seedance 2.5 Text to Video" ``` Without this, the next full sync would revert the English titles that Comfy-Org/docs#2107 sets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:10:46 +00:00