[PR #97] [MERGED] fix(groom): distinguish inferred impact from incidents #107

New issue

Closed

opened 2026-10-26 22:36:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:36:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/97
Author: @huntcsg
Created: 7/31/2026
Status: ✅ Merged
Merged: 7/31/2026
Merged by: @huntcsg

Base: main ← Head: fix/groom-evidence-tense

📝 Commits (1)

7af30be fix(groom): distinguish inferred impact from incidents

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 .github/groom/builder.md (+4 -3)
📝 .github/groom/verifier.md (+2 -0)

📄 Description

Summary

Require builder-authored PR prose to use conditional or counterfactual tense for runtime impacts inferred from code, tests, or reproductions.
Permit historical incident language only when explicit runtime evidence establishes that the event occurred.
Apply the same safeguard to verifier bodies because their rationale is appended to generated PRs.
Clarify that a regression test proves behavior under test conditions, not production occurrence.

Root cause

The builder treated a verifier body labeled VERIFIED as sufficient grounding for an ELI-5 and risk narrative, without distinguishing repository-proven behavior from observed runtime history. That let a plausible impact inferred from code be stated as an incident that had already happened.

Validation

python3 -m unittest discover -s .github/groom/tests -p 'test_*.py' -v — 120 passed
git diff --check — passed
python3 .github/agents-md-integrity/check_agents_md.py --root . — passed with the repository's existing no-CODEOWNERS warning

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/97 **Author:** [@huntcsg](https://github.com/huntcsg) **Created:** 7/31/2026 **Status:** ✅ Merged **Merged:** 7/31/2026 **Merged by:** [@huntcsg](https://github.com/huntcsg) **Base:** `main` ← **Head:** `fix/groom-evidence-tense` --- ### 📝 Commits (1) - [`7af30be`](https://github.com/Comfy-Org/github-workflows/commit/7af30bee6aefd260b9f192e39b15f86386c88405) fix(groom): distinguish inferred impact from incidents ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/groom/builder.md` (+4 -3) 📝 `.github/groom/verifier.md` (+2 -0) </details> ### 📄 Description ## Summary - Require builder-authored PR prose to use conditional or counterfactual tense for runtime impacts inferred from code, tests, or reproductions. - Permit historical incident language only when explicit runtime evidence establishes that the event occurred. - Apply the same safeguard to verifier bodies because their rationale is appended to generated PRs. - Clarify that a regression test proves behavior under test conditions, not production occurrence. ## Root cause The builder treated a verifier body labeled VERIFIED as sufficient grounding for an ELI-5 and risk narrative, without distinguishing repository-proven behavior from observed runtime history. That let a plausible impact inferred from code be stated as an incident that had already happened. ## Validation - `python3 -m unittest discover -s .github/groom/tests -p 'test_*.py' -v` — 120 passed - `git diff --check` — passed - `python3 .github/agents-md-integrity/check_agents_md.py --root .` — passed with the repository's existing no-CODEOWNERS warning --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:36:17 +00:00