[PR #3] [MERGED] chore(cursor-review): move DM email-map roster out of the public repo #11

New issue

Closed

opened 2026-10-26 22:35:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:35:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/3
Author: @mattmillerai
Created: 6/2/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @mattmillerai

Base: main ← Head: chore/cursor-review-deroster

📝 Commits (1)

776df0c chore(cursor-review): move DM email-map roster out of the public repo

📊 Changes

4 files changed (+24 additions, -20 deletions)

View changed files

📝 .github/cursor-review/prompt-adversarial.md (+2 -2)
📝 .github/cursor-review/prompt-edge-case.md (+2 -2)
📝 .github/cursor-review/slack-notify.sh (+13 -16)
📝 .github/workflows/cursor-review.yml (+7 -0)

📄 Description

What

This is a public repo. The Cursor Review tooling carried two bits of internal info that didn't need to be here. No credentials were exposed — all secrets are already referenced via `secrets.*`/env. These are "internal info, now public" cleanups.

1. Team roster + email convention (`slack-notify.sh`)

The DM helper hardcoded a GitHub-handle → @comfy.org email-prefix map for ~10 teammates, which enumerated the roster and confirmed the email scheme in a public repo.

Moved to a JSON $DM_EMAIL_MAP env var, sourced from an org/repo Actions variable vars.CURSOR_REVIEW_DM_EMAIL_MAP.
It's config, not a credential, so a variable (not a secret) is the right home — visible to the org, not the public repo.
Fallback unchanged: if the variable is unset/empty, the script uses the GitHub handle as the email prefix verbatim — exactly what it already did for unmapped users. So nothing breaks if the variable isn't set; only handles that differ from their email prefix need an entry.

2. Internal service paths in prompt examples (`prompt-adversarial.md`, `prompt-edge-case.md`)

The few-shot examples cited real private-repo paths (services/ingest|inference|dispatcher/..., common/retrier.go), disclosing the service topology. Swapped for neutral generic paths (internal/api/handler.go, etc.). The example shape the models key off of is unchanged.

Required follow-up before this fully takes effect

Set the org (or repo) Actions variable so DMs keep routing correctly for handles that differ from their email prefix. JSON object, lowercase keys:

gh variable set CURSOR_REVIEW_DM_EMAIL_MAP --org Comfy-Org --body '{"<handle>":"<email-prefix>", ...}'

(Use the values previously hardcoded in slack-notify.sh — pull them from this PR's diff or the prior commit.) Until it's set, those specific users fall back to handle@comfy.org, which won't resolve for the handful whose handle ≠ prefix.

Test

bash -n slack-notify.sh passes.
DM lookup path is unchanged apart from where the override map comes from.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/3 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 6/2/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `chore/cursor-review-deroster` --- ### 📝 Commits (1) - [`776df0c`](https://github.com/Comfy-Org/github-workflows/commit/776df0c33be0de72c5b2b4762ca5cdcb2c0791cc) chore(cursor-review): move DM email-map roster out of the public repo ### 📊 Changes **4 files changed** (+24 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.github/cursor-review/prompt-adversarial.md` (+2 -2) 📝 `.github/cursor-review/prompt-edge-case.md` (+2 -2) 📝 `.github/cursor-review/slack-notify.sh` (+13 -16) 📝 `.github/workflows/cursor-review.yml` (+7 -0) </details> ### 📄 Description ## What This is a public repo. The Cursor Review tooling carried two bits of internal info that didn't need to be here. No credentials were exposed — all secrets are already referenced via \`secrets.*\`/env. These are "internal info, now public" cleanups. ### 1. Team roster + email convention (`slack-notify.sh`) The DM helper hardcoded a GitHub-handle → `@comfy.org` email-prefix map for ~10 teammates, which enumerated the roster and confirmed the email scheme in a public repo. - Moved to a JSON `$DM_EMAIL_MAP` env var, sourced from an **org/repo Actions variable** `vars.CURSOR_REVIEW_DM_EMAIL_MAP`. - It's config, not a credential, so a variable (not a secret) is the right home — visible to the org, not the public repo. - **Fallback unchanged:** if the variable is unset/empty, the script uses the GitHub handle as the email prefix verbatim — exactly what it already did for unmapped users. So nothing breaks if the variable isn't set; only handles that differ from their email prefix need an entry. ### 2. Internal service paths in prompt examples (`prompt-adversarial.md`, `prompt-edge-case.md`) The few-shot examples cited real private-repo paths (`services/ingest|inference|dispatcher/...`, `common/retrier.go`), disclosing the service topology. Swapped for neutral generic paths (`internal/api/handler.go`, etc.). The example *shape* the models key off of is unchanged. ## Required follow-up before this fully takes effect Set the org (or repo) Actions variable so DMs keep routing correctly for handles that differ from their email prefix. JSON object, **lowercase keys**: ``` gh variable set CURSOR_REVIEW_DM_EMAIL_MAP --org Comfy-Org --body '{"<handle>":"<email-prefix>", ...}' ``` (Use the values previously hardcoded in `slack-notify.sh` — pull them from this PR's diff or the prior commit.) Until it's set, those specific users fall back to `handle@comfy.org`, which won't resolve for the handful whose handle ≠ prefix. ## Test - `bash -n slack-notify.sh` passes. - DM lookup path is unchanged apart from where the override map comes from. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:35:24 +00:00