[PR #2] [MERGED] fix(cursor-review): correct Matt's handle in slack-notify DM map #12

Closed
opened 2026-10-26 22:35:24 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/2
Author: @mattmillerai
Created: 6/2/2026
Status: ✅ Merged
Merged: 6/2/2026
Merged by: @mattmillerai

Base: main ← Head: fix/slack-notify-handle


📝 Commits (1)

  • 8c2e4a3 fix(cursor-review): correct Matt's handle in slack-notify DM map

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 .github/cursor-review/slack-notify.sh (+1 -1)

📄 Description

The centralized slack-notify.sh (sourced from comfy-cloud-mcp-server in #1) still maps the retired millermedia GitHub handle. That handle now belongs to a different account, so cursor-review DMs to Matt resolve the wrong email (or none). cloud's copy already uses mattmillerai; this matches it.

  • One-key change: GITHUB_EMAIL_MAP[millermedia] → GITHUB_EMAIL_MAP[mattmillerai]. Rest of the map is byte-identical to cloud's.
  • Fixes mcp-server's cursor-review DM routing (currently misrouted via the reusable workflow), and is a prerequisite for migrating cloud — without it, cloud would regress from its already-correct handle.

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/2 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 6/2/2026 **Status:** ✅ Merged **Merged:** 6/2/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `fix/slack-notify-handle` --- ### 📝 Commits (1) - [`8c2e4a3`](https://github.com/Comfy-Org/github-workflows/commit/8c2e4a30d07e0383094d5d86cfa0cb6980c6a9cc) fix(cursor-review): correct Matt's handle in slack-notify DM map ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/cursor-review/slack-notify.sh` (+1 -1) </details> ### 📄 Description The centralized `slack-notify.sh` (sourced from `comfy-cloud-mcp-server` in #1) still maps the **retired** `millermedia` GitHub handle. That handle now belongs to a different account, so cursor-review DMs to Matt resolve the wrong email (or none). `cloud`'s copy already uses `mattmillerai`; this matches it. - One-key change: `GITHUB_EMAIL_MAP[millermedia]` → `GITHUB_EMAIL_MAP[mattmillerai]`. Rest of the map is byte-identical to cloud's. - Fixes mcp-server's cursor-review DM routing (currently misrouted via the reusable workflow), and is a prerequisite for migrating `cloud` — without it, cloud would *regress* from its already-correct handle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:35:24 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/github-workflows#12
No description provided.