[PR #175] [MERGED] fix(cursor-review): resolve PR merge base before review #183

New issue

Closed

opened 2026-10-26 22:37:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:37:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/175
Author: @huntcsg
Created: 8/17/2026
Status: ✅ Merged
Merged: 8/17/2026
Merged by: @huntcsg

Base: main ← Head: cursor-review-fixed-merge-base

📝 Commits (1)

2266baf fix(cursor-review): resolve PR merge base before review

📊 Changes

3 files changed (+69 additions, -11 deletions)

View changed files

📝 .github/workflows/cursor-review.yml (+5 -0)
📝 scripts/check-pr-size/main.go (+33 -11)
📝 scripts/check-pr-size/main_test.go (+31 -0)

📄 Description

Summary

resolve the PR head's merge base against the current target-branch tip once
use that exact commit for generated-file classification, size counting, and reviewed diff generation
cover an unrebased PR after main advances with a regression test

Testing

go test ./... in scripts/check-pr-size
python3 -m unittest discover -s .github/cursor-review/tests -p 'test_*.py' -v
workflow-pins test suite and checker
git diff --check

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/175 **Author:** [@huntcsg](https://github.com/huntcsg) **Created:** 8/17/2026 **Status:** ✅ Merged **Merged:** 8/17/2026 **Merged by:** [@huntcsg](https://github.com/huntcsg) **Base:** `main` ← **Head:** `cursor-review-fixed-merge-base` --- ### 📝 Commits (1) - [`2266baf`](https://github.com/Comfy-Org/github-workflows/commit/2266baf79a5591a3d686436f444bcc1e4a18d89e) fix(cursor-review): resolve PR merge base before review ### 📊 Changes **3 files changed** (+69 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cursor-review.yml` (+5 -0) 📝 `scripts/check-pr-size/main.go` (+33 -11) 📝 `scripts/check-pr-size/main_test.go` (+31 -0) </details> ### 📄 Description ## Summary - resolve the PR head's merge base against the current target-branch tip once - use that exact commit for generated-file classification, size counting, and reviewed diff generation - cover an unrebased PR after main advances with a regression test ## Testing - `go test ./...` in `scripts/check-pr-size` - `python3 -m unittest discover -s .github/cursor-review/tests -p 'test_*.py' -v` - workflow-pins test suite and checker - `git diff --check` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:37:07 +00:00