[PR #215] [MERGED] ci(coderabbit-config): refresh the vendored CodeRabbit schema #221

New issue

Closed

opened 2026-10-26 22:37:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:37:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/215
Author: @cloud-code-bot[bot]
Created: 8/24/2026
Status: ✅ Merged
Merged: 8/24/2026
Merged by: @mattmillerai

Base: main ← Head: ci/refresh-coderabbit-schema

📝 Commits (2)

d829a68 ci(coderabbit-config): refresh the vendored CodeRabbit schema
ebb993d fix(coderabbit-config): bump the omitted-node openness count for the verilator addition

📊 Changes

2 files changed (+22 additions, -10 deletions)

View changed files

📝 .github/coderabbit-config/schema.v2.json (+21 -9)
📝 .github/coderabbit-config/tests/test_check_coderabbit_config.py (+1 -1)

📄 Description

Upstream's CodeRabbit config schema has drifted from the copy vendored here, which is what coderabbit-config-validate.yml grades every enrolled repo against.

Added properties (2):

reviews.tools.verilator
reviews.tools.verilator.enabled

Before merging, check the tightened-cap section above if there is one: a lowered maxLength retroactively invalidates configs nobody has touched, and merging this makes their next PR red. Landing the cleanup alongside is usually the right order.

Warning

The invariant unit suite FAILS against the proposed schema (this run). That suite asserts the exact facts the checker's messages rest on, so this is the signal to read closely, not a flake: either the schema change is one we must adapt the checker and its tests to, or the fetch is not what we think it is. Update those assertions in this PR, deliberately, before merging.

Invariant suite output

...................................................................F...............................
======================================================================
FAIL: test_the_two_halves_partition_the_objects_that_declare_properties (test_check_coderabbit_config.OpennessTest.test_the_two_halves_partition_the_objects_that_declare_properties)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_check_coderabbit_config.py", line 1060, in test_the_two_halves_partition_the_objects_that_declare_properties
    self.assertEqual(len(omitted), 103)
AssertionError: 104 != 103

----------------------------------------------------------------------
Ran 99 tests in 2.815s

FAILED (failures=1)

Merging this touches .github/coderabbit-config/**, which triggers bump-coderabbit-config-callers.yml and rolls the SHA-pinned caller fleet forward.

Opened by the refresh-coderabbit-schema workflow.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/215 **Author:** [@cloud-code-bot[bot]](https://github.com/apps/cloud-code-bot) **Created:** 8/24/2026 **Status:** ✅ Merged **Merged:** 8/24/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `ci/refresh-coderabbit-schema` --- ### 📝 Commits (2) - [`d829a68`](https://github.com/Comfy-Org/github-workflows/commit/d829a6864a0643328f9ffa653d4e9823ff6cd5eb) ci(coderabbit-config): refresh the vendored CodeRabbit schema - [`ebb993d`](https://github.com/Comfy-Org/github-workflows/commit/ebb993df8de09c1d0042d7b6bf50f485ae8f585f) fix(coderabbit-config): bump the omitted-node openness count for the verilator addition ### 📊 Changes **2 files changed** (+22 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/coderabbit-config/schema.v2.json` (+21 -9) 📝 `.github/coderabbit-config/tests/test_check_coderabbit_config.py` (+1 -1) </details> ### 📄 Description Upstream's CodeRabbit config schema has drifted from the copy vendored here, which is what `coderabbit-config-validate.yml` grades every enrolled repo against. **Added properties** (2): - `reviews.tools.verilator` - `reviews.tools.verilator.enabled` **Before merging**, check the tightened-cap section above if there is one: a lowered `maxLength` retroactively invalidates configs nobody has touched, and merging this makes their next PR red. Landing the cleanup alongside is usually the right order. > [!WARNING] > **The invariant unit suite FAILS against the proposed schema** ([this run](https://github.com/Comfy-Org/github-workflows/actions/runs/32743667310)). That suite asserts the exact facts the checker's messages rest on, so this is the signal to read closely, not a flake: either the schema change is one we must adapt the checker and its tests to, or the fetch is not what we think it is. Update those assertions in this PR, deliberately, before merging. <details><summary>Invariant suite output</summary> ``` ...................................................................F............................... ====================================================================== FAIL: test_the_two_halves_partition_the_objects_that_declare_properties (test_check_coderabbit_config.OpennessTest.test_the_two_halves_partition_the_objects_that_declare_properties) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_check_coderabbit_config.py", line 1060, in test_the_two_halves_partition_the_objects_that_declare_properties self.assertEqual(len(omitted), 103) AssertionError: 104 != 103 ---------------------------------------------------------------------- Ran 99 tests in 2.815s FAILED (failures=1) ``` </details> Merging this touches `.github/coderabbit-config/**`, which triggers `bump-coderabbit-config-callers.yml` and rolls the SHA-pinned caller fleet forward. _Opened by the `refresh-coderabbit-schema` workflow._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:37:31 +00:00