[PR #252] [CLOSED] feat(pr-risk): use named risk tiers #257

New issue

Closed

opened 2026-10-26 22:37:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:37:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/252
Author: @huang47
Created: 9/1/2026
Status: ❌ Closed

Base: main ← Head: cx/named-risk-tiers

📝 Commits (5)

415c6d7 feat(pr-risk): use canonical named tiers
8153310 feat(pr-risk): support named risk labels
da3f574 feat(pr-risk): render canonical tier names
0aec41d feat(pr-derisk): use canonical tier names
9695f7f docs(pr-risk): document named risk tiers

📊 Changes

18 files changed (+610 additions, -439 deletions)

View changed files

📝 .github/workflows/pr-risk.yml (+19 -15)
📝 README.md (+2 -2)
📝 docs/callers/pr-risk.md (+12 -7)
📝 scripts/pr-derisk/README.md (+5 -5)
📝 scripts/pr-derisk/plan-derisk.sh (+4 -4)
📝 scripts/pr-derisk/publish-derisk-comment.sh (+17 -4)
📝 scripts/pr-derisk/tests/test_plan_derisk.sh (+25 -15)
📝 scripts/pr-risk/README.md (+50 -34)
📝 scripts/pr-risk/apply-risk-label.sh (+49 -18)
📝 scripts/pr-risk/grade-pr-risk.sh (+80 -55)
📝 scripts/pr-risk/grade-targets.sh (+3 -3)
📝 scripts/pr-risk/publish-risk-surfaces.sh (+45 -27)
📝 scripts/pr-risk/risk-map.v0.json (+29 -28)
📝 scripts/pr-risk/runbook-registry.v0.json (+2 -2)
📝 scripts/pr-risk/tests/test_apply_risk_label.sh (+66 -46)
📝 scripts/pr-risk/tests/test_grade_pr_risk.sh (+106 -89)
📝 scripts/pr-risk/tests/test_grade_targets.sh (+15 -15)
📝 scripts/pr-risk/tests/test_publish_risk_surfaces.sh (+81 -70)

📄 Description

Summary:

make low, medium, high, and xhigh canonical across maps, graded records, labels, comments, and derisk plans
accept R0 through R3 in existing maps, TIER inputs, label_map keys, and historical render inputs as deprecated aliases
preserve every grading rule and rank exactly; normalize once at input boundaries
retire the former default risk:R0 through risk:R3 labels on the first canonical re-grade

Compatibility and rollout:

no new caller inputs, secrets, or permissions
this changes both the reusable workflow and runtime assets, so callers must bump uses and workflows_ref together
existing consumer maps continue to work with warnings; they can migrate after the merged shared SHA is pinned

Validation:

ShellCheck passed for all pr-risk and pr-derisk scripts and suites
all 451 pr-risk assertions passed
all 65 pr-derisk assertions passed
default map and registry passed the grader structural validator

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/252 **Author:** [@huang47](https://github.com/huang47) **Created:** 9/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cx/named-risk-tiers` --- ### 📝 Commits (5) - [`415c6d7`](https://github.com/Comfy-Org/github-workflows/commit/415c6d7fdaf8b01d2057e75bf9d596ba49a13730) feat(pr-risk): use canonical named tiers - [`8153310`](https://github.com/Comfy-Org/github-workflows/commit/815331057ebf2302b90e276364845bd8f7cc0f6f) feat(pr-risk): support named risk labels - [`da3f574`](https://github.com/Comfy-Org/github-workflows/commit/da3f57437e5cee99fa5092871c335199a33d6857) feat(pr-risk): render canonical tier names - [`0aec41d`](https://github.com/Comfy-Org/github-workflows/commit/0aec41dffef25bcb052d04e2e0a0366ccb97776c) feat(pr-derisk): use canonical tier names - [`9695f7f`](https://github.com/Comfy-Org/github-workflows/commit/9695f7fe1b4145ff0db754b3ced553b69df6fa15) docs(pr-risk): document named risk tiers ### 📊 Changes **18 files changed** (+610 additions, -439 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/pr-risk.yml` (+19 -15) 📝 `README.md` (+2 -2) 📝 `docs/callers/pr-risk.md` (+12 -7) 📝 `scripts/pr-derisk/README.md` (+5 -5) 📝 `scripts/pr-derisk/plan-derisk.sh` (+4 -4) 📝 `scripts/pr-derisk/publish-derisk-comment.sh` (+17 -4) 📝 `scripts/pr-derisk/tests/test_plan_derisk.sh` (+25 -15) 📝 `scripts/pr-risk/README.md` (+50 -34) 📝 `scripts/pr-risk/apply-risk-label.sh` (+49 -18) 📝 `scripts/pr-risk/grade-pr-risk.sh` (+80 -55) 📝 `scripts/pr-risk/grade-targets.sh` (+3 -3) 📝 `scripts/pr-risk/publish-risk-surfaces.sh` (+45 -27) 📝 `scripts/pr-risk/risk-map.v0.json` (+29 -28) 📝 `scripts/pr-risk/runbook-registry.v0.json` (+2 -2) 📝 `scripts/pr-risk/tests/test_apply_risk_label.sh` (+66 -46) 📝 `scripts/pr-risk/tests/test_grade_pr_risk.sh` (+106 -89) 📝 `scripts/pr-risk/tests/test_grade_targets.sh` (+15 -15) 📝 `scripts/pr-risk/tests/test_publish_risk_surfaces.sh` (+81 -70) </details> ### 📄 Description Summary: - make low, medium, high, and xhigh canonical across maps, graded records, labels, comments, and derisk plans - accept R0 through R3 in existing maps, TIER inputs, label_map keys, and historical render inputs as deprecated aliases - preserve every grading rule and rank exactly; normalize once at input boundaries - retire the former default risk:R0 through risk:R3 labels on the first canonical re-grade Compatibility and rollout: - no new caller inputs, secrets, or permissions - this changes both the reusable workflow and runtime assets, so callers must bump uses and workflows_ref together - existing consumer maps continue to work with warnings; they can migrate after the merged shared SHA is pinned Validation: - ShellCheck passed for all pr-risk and pr-derisk scripts and suites - all 451 pr-risk assertions passed - all 65 pr-derisk assertions passed - default map and registry passed the grader structural validator --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:37:50 +00:00