[PR #260] fix(linear-ticket): ignore post-close signal runs #261

New issue

Open

opened 2026-10-26 22:37:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:37:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/260
Author: @christian-byrne
Created: 9/3/2026
Status: 🔄 Open

Base: main ← Head: christian-byrne/fix-linear-ticket-post-merge

📝 Commits (3)

e4ef729 fix(linear-ticket): ignore post-close signal runs
4c79d88 fix(linear-ticket): fail closed resolving completed PRs
32a4f1e Merge remote-tracking branch 'origin/main' into codex/pr260-refresh

📊 Changes

2 files changed (+117 additions, -17 deletions)

View changed files

📝 scripts/linear-ticket/tests/test_validate.py (+73 -2)
📝 scripts/linear-ticket/validate.py (+44 -15)

📄 Description

Summary

treat an exact-head PR that closes before its workflow_run validator starts as a completed no-op
keep ambiguous or missing PR associations fail-closed
add a regression covering the post-merge empty-pull_requests payload

Why

A signal run can finish after its PR merges. GitHub then supplies an empty workflow_run.pull_requests list; the commit association still identifies the now-closed exact-head PR. Requiring one open PR makes the privileged validator fail after the gate has already completed.

Verification

python3 -m unittest discover -s scripts/linear-ticket/tests -p 'test_*.py' -v (75 tests)
python3 -m py_compile scripts/linear-ticket/validate.py scripts/linear-ticket/tests/test_validate.py
git diff --check

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/260 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 9/3/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `christian-byrne/fix-linear-ticket-post-merge` --- ### 📝 Commits (3) - [`e4ef729`](https://github.com/Comfy-Org/github-workflows/commit/e4ef729276c16144bf259c464ec76e0d03e0eb6f) fix(linear-ticket): ignore post-close signal runs - [`4c79d88`](https://github.com/Comfy-Org/github-workflows/commit/4c79d883c5bccc01efed77ba01104c215bcf753c) fix(linear-ticket): fail closed resolving completed PRs - [`32a4f1e`](https://github.com/Comfy-Org/github-workflows/commit/32a4f1e947afb33f0cb2ab1882f76e3e64389262) Merge remote-tracking branch 'origin/main' into codex/pr260-refresh ### 📊 Changes **2 files changed** (+117 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `scripts/linear-ticket/tests/test_validate.py` (+73 -2) 📝 `scripts/linear-ticket/validate.py` (+44 -15) </details> ### 📄 Description ## Summary - treat an exact-head PR that closes before its `workflow_run` validator starts as a completed no-op - keep ambiguous or missing PR associations fail-closed - add a regression covering the post-merge empty-`pull_requests` payload ## Why A signal run can finish after its PR merges. GitHub then supplies an empty `workflow_run.pull_requests` list; the commit association still identifies the now-closed exact-head PR. Requiring one *open* PR makes the privileged validator fail after the gate has already completed. ## Verification - `python3 -m unittest discover -s scripts/linear-ticket/tests -p 'test_*.py' -v` (75 tests) - `python3 -m py_compile scripts/linear-ticket/validate.py scripts/linear-ticket/tests/test_validate.py` - `git diff --check` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-26 22:37:53 +00:00

bsakaguchi referenced this issue

2026-10-26 22:37:53 +00:00

[PR #261] fix(groom): bound finder and builder exploration #264

bsakaguchi referenced this issue

2026-10-26 22:38:00 +00:00

[PR #275] [MERGED] feat(groom): optional environment input on the three token-minting jobs #276