[PR #383] [MERGED] fix(cursor-axis-base): carry the Cursor CLI pin forward to match cursor-review #384

New issue

Closed

opened 2026-10-26 22:39:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:39:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/383
Author: @mattmillerai
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/8/2026
Merged by: @mattmillerai

Base: main ← Head: matt/sync-axis-cursor-cli-pin

📝 Commits (1)

5cfde4d fix(cursor-axis-base): carry the Cursor CLI pin forward to match cursor-review

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/cursor-axis-base.yml (+2 -2)

📄 Description

What

Two lines in .github/workflows/cursor-axis-base.yml: the pinned Cursor CLI version and its SHA256, moved forward to the values cursor-review.yml already pins.

	before	after
`CURSOR_CLI_VERSION`	`2026.09.10-fd3934a`	`2026.10.01-e373342`
`CURSOR_CLI_SHA256`	`27997c83…66e96e`	`a79726c6…66ae28e8`

Why

cursor-review.yml was bumped in #335 and this file was not carried along, so the panel and the approve axes have been installing different CLI builds since then.

test_cli_pin_matches_cursor_review asserts the two are equal, and the comment above the pin states the same intent — "Same pin as cursor-review.yml's (a test keeps them equal)". That test has therefore been failing Test cursor-review scripts / unittest + shellcheck on every PR in this repo regardless of its contents, which makes a genuine regression in that job easy to miss.

Forward is the correct direction: cursor-review.yml is already on the October build, and these values are the ones it pins.

Verification

cursor-approve suite: 166 tests, OK (1 skipped) — was 1 failure, test_cli_pin_matches_cursor_review.
Diff is exactly 2 lines in 1 file; no logic, no other pin touched.

Note for reviewers

This moves the CLI build underneath the approve axes, not just the panel — worth a glance if anything depended on the September build. Nothing in the repo appears to, and the test's existence says equality is the intended invariant.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/383 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/8/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/sync-axis-cursor-cli-pin` --- ### 📝 Commits (1) - [`5cfde4d`](https://github.com/Comfy-Org/github-workflows/commit/5cfde4de259d4ebda80a1ae1a6e33667e11a5b70) fix(cursor-axis-base): carry the Cursor CLI pin forward to match cursor-review ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cursor-axis-base.yml` (+2 -2) </details> ### 📄 Description ## What Two lines in `.github/workflows/cursor-axis-base.yml`: the pinned Cursor CLI version and its SHA256, moved forward to the values `cursor-review.yml` already pins. | | before | after | |---|---|---| | `CURSOR_CLI_VERSION` | `2026.09.10-fd3934a` | `2026.10.01-e373342` | | `CURSOR_CLI_SHA256` | `27997c83…66e96e` | `a79726c6…66ae28e8` | ## Why `cursor-review.yml` was bumped in #335 and this file was not carried along, so the panel and the approve axes have been installing different CLI builds since then. `test_cli_pin_matches_cursor_review` asserts the two are equal, and the comment above the pin states the same intent — *"Same pin as cursor-review.yml's (a test keeps them equal)"*. That test has therefore been failing `Test cursor-review scripts / unittest + shellcheck` on **every** PR in this repo regardless of its contents, which makes a genuine regression in that job easy to miss. Forward is the correct direction: `cursor-review.yml` is already on the October build, and these values are the ones it pins. ## Verification - `cursor-approve` suite: **166 tests, OK** (1 skipped) — was 1 failure, `test_cli_pin_matches_cursor_review`. - Diff is exactly 2 lines in 1 file; no logic, no other pin touched. ## Note for reviewers This moves the CLI build underneath the approve axes, not just the panel — worth a glance if anything depended on the September build. Nothing in the repo appears to, and the test's existence says equality is the intended invariant. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:39:14 +00:00