[PR #35] [MERGED] ci: register pr-size as a caller fleet on the shared bump-callers.sh #42

New issue

Closed

opened 2026-10-26 22:35:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:35:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/35
Author: @mattmillerai
Created: 7/18/2026
Status: ✅ Merged
Merged: 7/21/2026
Merged by: @mattmillerai

Base: main ← Head: matt/be-3482-generalize-bump-callers

📝 Commits (5)

f8e1287 ci: generalize bump-cursor-review-callers into a multi-workflow bump-callers dispatcher
6a06c96 Merge main: adopt the shared bump-callers.sh entrypoint pattern for pr-size
c26fe33 fix: resolve review feedback
55bd592 Merge remote-tracking branch 'origin/main' into matt/be-3482-generalize-bump-callers
ed6b9ad fix: resolve review feedback

📊 Changes

7 files changed (+124 additions, -22 deletions)

View changed files

📝 .github/bump-callers/README.md (+12 -7)
📝 .github/bump-callers/bump-callers.sh (+6 -5)
📝 .github/workflows/bump-agents-md-callers.yml (+3 -0)
📝 .github/workflows/bump-cursor-review-callers.yml (+3 -0)
➕ .github/workflows/bump-pr-size-callers.yml (+86 -0)
📝 .github/workflows/test-bump-callers.yml (+6 -4)
📝 AGENTS.md (+8 -6)

📄 Description

ELI-5

This PR started as "turn the one cursor-review bump robot into a dispatcher that
also handles pr-size." While it was open, main landed #38,
which generalized the same bump robot a different way: one shared script
(.github/bump-callers/bump-callers.sh) driven by a thin per-fleet entrypoint
workflow, and used it to add a second fleet (agents-md-integrity). This PR now
reconciles with that: instead of a second, competing dispatcher implementation,
it registers pr-size as a third fleet on the now-shared script, the same way
agents-md-integrity was added.

What changed (revised after merging in #38)

bump-pr-size-callers.yml — a new thin entrypoint over
.github/bump-callers/bump-callers.sh, mirroring bump-agents-md-callers.yml
exactly: triggers on a change to pr-size.yml, uses the PR_SIZE_CALLERS
variable, and is seeded ALLOW_EMPTY=true (the workflow hasn't landed yet, so
the fleet grows as callers get added — no different from how agents-md-integrity
onboarded).
.github/bump-callers/README.md, bump-callers.sh's header comment,
test-bump-callers.yml's path filters, and AGENTS.md updated for the third
fleet.
The original bump-callers.yml single-dispatcher design (registry + compare-API
push resolution + workflows/dry_run dispatch inputs) is dropped — it
would have re-forked the bump logic #38 just consolidated into one script,
which is exactly what #38's own commit message (and this repo's AGENTS.md,
"One bumper, not several") says not to do. The per-workflow paths: trigger
each entrypoint already has does the same "only bump what actually changed"
job the compare-API resolution was for, natively.

Verification

shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh — clean.
bash .github/bump-callers/tests/test_bump_callers.sh — 25/25 passing, unchanged
(the shared script itself wasn't touched, only a new caller of it was added).
python3 .github/agents-md-integrity/check_agents_md.py --root . — passes
(pre-existing CODEOWNERS warning only).
Diffed bump-pr-size-callers.yml against bump-agents-md-callers.yml to confirm
only the intended per-fleet parameters differ (name, trigger path, VAR_NAME,
TAG, WORKFLOW_FILE).

Judgment calls / notes for the reviewer

No PR_SIZE_CALLERS variable is seeded yet — same bootstrapping as
AGENTS_MD_CALLERS was: ALLOW_EMPTY=true makes the entrypoint a clean no-op
until the pr-size rollout starts adding callers.
If pr-size.yml lands under a different filename than assumed here, the fix is
the WORKFLOW_FILE/path-filter in bump-pr-size-callers.yml alone.

Follow-up fix (same tick)

Restored permissions: contents: read (this PR's original zizmor-driven fix)
across all three bump-*-callers.yml entrypoints — main's #38 merge and
this PR's new bump-pr-size-callers.yml had all landed without an explicit
permissions: block. None of these jobs write via GITHUB_TOKEN (writes go
through the generated app token), so read-only is correct, and it now matches
every other workflow file in this repo (all of which declare explicit
permissions).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/35 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 7/18/2026 **Status:** ✅ Merged **Merged:** 7/21/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/be-3482-generalize-bump-callers` --- ### 📝 Commits (5) - [`f8e1287`](https://github.com/Comfy-Org/github-workflows/commit/f8e1287c4fe7084a620a03d96da5cd8696a8e74b) ci: generalize bump-cursor-review-callers into a multi-workflow bump-callers dispatcher - [`6a06c96`](https://github.com/Comfy-Org/github-workflows/commit/6a06c9683688e09a419c7147e6b22f79887e32d0) Merge main: adopt the shared bump-callers.sh entrypoint pattern for pr-size - [`c26fe33`](https://github.com/Comfy-Org/github-workflows/commit/c26fe337503a88f236d3466598f4bdd40c0ef624) fix: resolve review feedback - [`55bd592`](https://github.com/Comfy-Org/github-workflows/commit/55bd5920de44fe8740f6b6aeed7e0bd1e6ca3f5f) Merge remote-tracking branch 'origin/main' into matt/be-3482-generalize-bump-callers - [`ed6b9ad`](https://github.com/Comfy-Org/github-workflows/commit/ed6b9ade349a83228461720caa7f76a98c807d81) fix: resolve review feedback ### 📊 Changes **7 files changed** (+124 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `.github/bump-callers/README.md` (+12 -7) 📝 `.github/bump-callers/bump-callers.sh` (+6 -5) 📝 `.github/workflows/bump-agents-md-callers.yml` (+3 -0) 📝 `.github/workflows/bump-cursor-review-callers.yml` (+3 -0) ➕ `.github/workflows/bump-pr-size-callers.yml` (+86 -0) 📝 `.github/workflows/test-bump-callers.yml` (+6 -4) 📝 `AGENTS.md` (+8 -6) </details> ### 📄 Description ## ELI-5 This PR started as "turn the one cursor-review bump robot into a dispatcher that also handles pr-size." While it was open, `main` landed [#38](https://github.com/Comfy-Org/github-workflows/pull/38), which generalized the *same* bump robot a different way: one shared script (`.github/bump-callers/bump-callers.sh`) driven by a thin per-fleet entrypoint workflow, and used it to add a second fleet (agents-md-integrity). This PR now reconciles with that: instead of a second, competing dispatcher implementation, it registers **pr-size** as a third fleet on the now-shared script, the same way agents-md-integrity was added. ## What changed (revised after merging in #38) - **`bump-pr-size-callers.yml`** — a new thin entrypoint over `.github/bump-callers/bump-callers.sh`, mirroring `bump-agents-md-callers.yml` exactly: triggers on a change to `pr-size.yml`, uses the `PR_SIZE_CALLERS` variable, and is seeded `ALLOW_EMPTY=true` (the workflow hasn't landed yet, so the fleet grows as callers get added — no different from how agents-md-integrity onboarded). - `.github/bump-callers/README.md`, `bump-callers.sh`'s header comment, `test-bump-callers.yml`'s path filters, and `AGENTS.md` updated for the third fleet. - The original `bump-callers.yml` single-dispatcher design (registry + compare-API push resolution + `workflows`/`dry_run` dispatch inputs) is **dropped** — it would have re-forked the bump logic #38 just consolidated into one script, which is exactly what #38's own commit message (and this repo's `AGENTS.md`, "One bumper, not several") says not to do. The per-workflow `paths:` trigger each entrypoint already has does the same "only bump what actually changed" job the compare-API resolution was for, natively. ## Verification - `shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh` — clean. - `bash .github/bump-callers/tests/test_bump_callers.sh` — 25/25 passing, unchanged (the shared script itself wasn't touched, only a new caller of it was added). - `python3 .github/agents-md-integrity/check_agents_md.py --root .` — passes (pre-existing CODEOWNERS warning only). - Diffed `bump-pr-size-callers.yml` against `bump-agents-md-callers.yml` to confirm only the intended per-fleet parameters differ (name, trigger path, `VAR_NAME`, `TAG`, `WORKFLOW_FILE`). ## Judgment calls / notes for the reviewer - **No `PR_SIZE_CALLERS` variable is seeded yet** — same bootstrapping as `AGENTS_MD_CALLERS` was: `ALLOW_EMPTY=true` makes the entrypoint a clean no-op until the pr-size rollout starts adding callers. - If `pr-size.yml` lands under a different filename than assumed here, the fix is the `WORKFLOW_FILE`/path-filter in `bump-pr-size-callers.yml` alone. ## Follow-up fix (same tick) Restored `permissions: contents: read` (this PR's original zizmor-driven fix) across **all three** `bump-*-callers.yml` entrypoints — main's #38 merge and this PR's new `bump-pr-size-callers.yml` had all landed without an explicit `permissions:` block. None of these jobs write via `GITHUB_TOKEN` (writes go through the generated app token), so read-only is correct, and it now matches every other workflow file in this repo (all of which declare explicit permissions). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:35:40 +00:00