[PR #48] [MERGED] ci(bump-callers): trigger the pr-size fleet on the Go counter source, not just pr-size.yml (BE-3482) #56

New issue

Closed

opened 2026-10-26 22:35:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:35:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/48
Author: @mattmillerai
Created: 7/21/2026
Status: ✅ Merged
Merged: 7/21/2026
Merged by: @mattmillerai

Base: main ← Head: matt/be-3482-bump-pr-size-fleet-trigger-fix

📝 Commits (1)

3eb1629 fix: resolve review feedback

📊 Changes

4 files changed (+17 additions, -10 deletions)

View changed files

📝 .github/bump-callers/README.md (+1 -1)
📝 .github/workflows/bump-agents-md-callers.yml (+6 -5)
📝 .github/workflows/bump-cursor-review-callers.yml (+5 -4)
📝 .github/workflows/bump-pr-size-callers.yml (+5 -0)

📄 Description

Fast-follow to #35 (merged): a self-review pass caught this after #35 landed, so
it's a small standalone PR rather than reopening the merged one.

What

bump-pr-size-callers.yml only triggered on changes to pr-size.yml itself.
But the actual counting logic consumers run lives in scripts/check-pr-size/**
— pr-size.yml's own header says the size job builds that Go tool from the
workflows_ref SHA a caller pins, mirroring how cursor-review.yml checks out
.github/cursor-review/* at the same pinned ref. So a behavior-changing edit
to the Go counter wouldn't trigger a caller SHA-bump, and pinned callers would
silently keep running stale tool behavior.

Fix: add scripts/check-pr-size/** to the fleet's trigger paths (mirroring how
bump-agents-md-callers.yml already watches both its workflow file and
.github/agents-md-integrity/**), and update the README fleet table row to
match. Also cleaned up two stale "two entrypoints" comments in the sibling
fleet files left over from before #35 added the third fleet.

Test plan

shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh
bash .github/bump-callers/tests/test_bump_callers.sh (86/86 pass)
YAML-parsed all three touched workflow files

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/48 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 7/21/2026 **Status:** ✅ Merged **Merged:** 7/21/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/be-3482-bump-pr-size-fleet-trigger-fix` --- ### 📝 Commits (1) - [`3eb1629`](https://github.com/Comfy-Org/github-workflows/commit/3eb1629d69427f7032a69cd7f6b86298654d28aa) fix: resolve review feedback ### 📊 Changes **4 files changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/bump-callers/README.md` (+1 -1) 📝 `.github/workflows/bump-agents-md-callers.yml` (+6 -5) 📝 `.github/workflows/bump-cursor-review-callers.yml` (+5 -4) 📝 `.github/workflows/bump-pr-size-callers.yml` (+5 -0) </details> ### 📄 Description Fast-follow to #35 (merged): a self-review pass caught this after #35 landed, so it's a small standalone PR rather than reopening the merged one. ## What `bump-pr-size-callers.yml` only triggered on changes to `pr-size.yml` itself. But the actual counting logic consumers run lives in `scripts/check-pr-size/**` — `pr-size.yml`'s own header says the size job builds that Go tool from the `workflows_ref` SHA a caller pins, mirroring how `cursor-review.yml` checks out `.github/cursor-review/*` at the same pinned ref. So a behavior-changing edit to the Go counter wouldn't trigger a caller SHA-bump, and pinned callers would silently keep running stale tool behavior. Fix: add `scripts/check-pr-size/**` to the fleet's trigger paths (mirroring how `bump-agents-md-callers.yml` already watches both its workflow file and `.github/agents-md-integrity/**`), and update the README fleet table row to match. Also cleaned up two stale "two entrypoints" comments in the sibling fleet files left over from before #35 added the third fleet. ## Test plan - [x] `shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh` - [x] `bash .github/bump-callers/tests/test_bump_callers.sh` (86/86 pass) - [x] YAML-parsed all three touched workflow files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:35:48 +00:00