[PR #60] [CLOSED] ci(bump-callers): add cursor-review-auto-label caller fleet (BE-4005) #69

New issue

Closed

opened 2026-10-26 22:35:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:35:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/60
Author: @mattmillerai
Created: 7/22/2026
Status: ❌ Closed

Base: main ← Head: matt/be-4005-bump-cursor-review-auto-label-callers

📝 Commits (3)

765a2c9 ci(bump-callers): add cursor-review-auto-label caller fleet (BE-4005)
89e3110 ci(bump-callers): harden auto-label bumper per review (SHA-pin checkout, main-only guard, deletion no-op) (BE-4005)
1513c4a Merge branch 'main' into matt/be-4005-bump-cursor-review-auto-label-callers

📊 Changes

6 files changed (+174 additions, -15 deletions)

View changed files

📝 .github/bump-callers/README.md (+1 -0)
📝 .github/bump-callers/bump-callers.sh (+4 -4)
📝 .github/bump-callers/tests/test_bump_callers.sh (+41 -1)
➕ .github/workflows/bump-cursor-review-auto-label-callers.yml (+114 -0)
📝 .github/workflows/test-bump-callers.yml (+8 -5)
📝 AGENTS.md (+6 -5)

📄 Description

ELI-5

This repo auto-opens "update your pin" PRs in consumer repos whenever one of its reusable workflows changes — one little bumper workflow per reusable. cursor-review-auto-label.yml never got a bumper, so every repo using it slowly fell behind (while its sibling ci-cursor-review.yml caller stayed current, leaving the two cursor-review callers in a repo pinned to different commits of this repo). This PR adds the missing bumper.

What

New .github/workflows/bump-cursor-review-auto-label-callers.yml — thin entrypoint over the shared bump-callers.sh, mirroring bump-cursor-review-callers.yml: triggers on push-to-main touching .github/workflows/cursor-review-auto-label.yml (plus workflow_dispatch for on-demand re-bumps), reads vars.CURSOR_REVIEW_AUTO_LABEL_CALLERS, opens one SHA-bump PR per consumer as Cloud Code Bot. Own concurrency group + stable branch (ci/bump-cursor-review-auto-label), per the BE-3882 serialization pattern.
.github/bump-callers/README.md — new fleet row in the table.
.github/workflows/test-bump-callers.yml — new entrypoint added to both path filters so wrapper changes run the suite.
.github/bump-callers/tests/test_bump_callers.sh — two new cases driving the fleet's exact entrypoint parameters (VAR_NAME/TAG/WORKFLOW_FILE/ALLOW_EMPTY): (1) two callers — mirroring the two real consumers — each get a SHA-bump PR with the pin rewritten, comment normalized, and repo names masked; (2) an unseeded/empty variable is a clean no-op. 100/100 checks pass locally, shellcheck clean, actionlint clean.
AGENTS.md catalog + two already-stale header comments synced (the shared script's header now points at the README fleet table instead of enumerating fleets, so it can't drift again).

⚠️ Manual follow-up required (repo variables are not in-repo files — this PR cannot create them)

After merge, seed the variable with the current consumers:

gh variable set CURSOR_REVIEW_AUTO_LABEL_CALLERS --repo Comfy-Org/github-workflows --body \
  '[{"repo":"Comfy-Org/cloud","file":".github/workflows/cursor-review-auto-label.yml","label":""},{"repo":"Comfy-Org/website","file":".github/workflows/cursor-review-auto-label.yml","label":""}]'

(Then optionally gh workflow run bump-cursor-review-auto-label-callers.yml to catch both consumers up immediately.) Also add the entries to the canonical callers.json in the private ops repo.

Judgment calls

ALLOW_EMPTY: "true" — deviates from the mirror target (CURSOR_REVIEW_CALLERS hard-fails when empty). Deliberate: the variable is repo config the merge itself cannot create, so hard-fail semantics would guarantee a red run for any reusable change landing in the merge→seed window. This matches the bump-assign-reviewers-callers.yml precedent (variable created out-of-band, seeded empty). Trade-off: if seeding is forgotten, the fleet no-ops silently — hence the loud follow-up above.
No WIRE_BOT_SCRIPT — the bot-identity injection (BE-1814) is cursor-review-specific by design (bump-cursor-review-callers.yml says it is "set only here"); auto-label callers already pass their own app creds per the reusable's contract.
actions/checkout@v6 (tag, not SHA) — byte-identical to all four sibling bumpers; kept consistent rather than diverging in one file.

Testing

shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh — clean
bash .github/bump-callers/tests/test_bump_callers.sh — 100 passed, 0 failed (12 new checks)
actionlint on both touched workflows — clean
python3 .github/agents-md-integrity/check_agents_md.py --root . — passed (pre-existing CODEOWNERS warning only)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/60 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 7/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `matt/be-4005-bump-cursor-review-auto-label-callers` --- ### 📝 Commits (3) - [`765a2c9`](https://github.com/Comfy-Org/github-workflows/commit/765a2c95bf916fd99f9649a79a4d03cd5b6f79ba) ci(bump-callers): add cursor-review-auto-label caller fleet (BE-4005) - [`89e3110`](https://github.com/Comfy-Org/github-workflows/commit/89e3110b9dd67458e1e35c91d7ec830fb7f2b9de) ci(bump-callers): harden auto-label bumper per review (SHA-pin checkout, main-only guard, deletion no-op) (BE-4005) - [`1513c4a`](https://github.com/Comfy-Org/github-workflows/commit/1513c4a3fe32b50dc459f2449a2e0b42097da743) Merge branch 'main' into matt/be-4005-bump-cursor-review-auto-label-callers ### 📊 Changes **6 files changed** (+174 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `.github/bump-callers/README.md` (+1 -0) 📝 `.github/bump-callers/bump-callers.sh` (+4 -4) 📝 `.github/bump-callers/tests/test_bump_callers.sh` (+41 -1) ➕ `.github/workflows/bump-cursor-review-auto-label-callers.yml` (+114 -0) 📝 `.github/workflows/test-bump-callers.yml` (+8 -5) 📝 `AGENTS.md` (+6 -5) </details> ### 📄 Description ## ELI-5 This repo auto-opens "update your pin" PRs in consumer repos whenever one of its reusable workflows changes — one little bumper workflow per reusable. `cursor-review-auto-label.yml` never got a bumper, so every repo using it slowly fell behind (while its sibling `ci-cursor-review.yml` caller stayed current, leaving the two cursor-review callers in a repo pinned to *different* commits of this repo). This PR adds the missing bumper. ## What - **New `.github/workflows/bump-cursor-review-auto-label-callers.yml`** — thin entrypoint over the shared `bump-callers.sh`, mirroring `bump-cursor-review-callers.yml`: triggers on push-to-main touching `.github/workflows/cursor-review-auto-label.yml` (plus `workflow_dispatch` for on-demand re-bumps), reads `vars.CURSOR_REVIEW_AUTO_LABEL_CALLERS`, opens one SHA-bump PR per consumer as Cloud Code Bot. Own concurrency group + stable branch (`ci/bump-cursor-review-auto-label`), per the BE-3882 serialization pattern. - **`.github/bump-callers/README.md`** — new fleet row in the table. - **`.github/workflows/test-bump-callers.yml`** — new entrypoint added to both path filters so wrapper changes run the suite. - **`.github/bump-callers/tests/test_bump_callers.sh`** — two new cases driving the fleet's *exact* entrypoint parameters (`VAR_NAME`/`TAG`/`WORKFLOW_FILE`/`ALLOW_EMPTY`): (1) two callers — mirroring the two real consumers — each get a SHA-bump PR with the pin rewritten, comment normalized, and repo names masked; (2) an unseeded/empty variable is a clean no-op. **100/100 checks pass** locally, `shellcheck` clean, `actionlint` clean. - **`AGENTS.md`** catalog + two already-stale header comments synced (the shared script's header now points at the README fleet table instead of enumerating fleets, so it can't drift again). ## ⚠️ Manual follow-up required (repo variables are not in-repo files — this PR cannot create them) After merge, seed the variable with the current consumers: ```bash gh variable set CURSOR_REVIEW_AUTO_LABEL_CALLERS --repo Comfy-Org/github-workflows --body \ '[{"repo":"Comfy-Org/cloud","file":".github/workflows/cursor-review-auto-label.yml","label":""},{"repo":"Comfy-Org/website","file":".github/workflows/cursor-review-auto-label.yml","label":""}]' ``` (Then optionally `gh workflow run bump-cursor-review-auto-label-callers.yml` to catch both consumers up immediately.) Also add the entries to the canonical `callers.json` in the private ops repo. ## Judgment calls - **`ALLOW_EMPTY: "true"`** — deviates from the mirror target (`CURSOR_REVIEW_CALLERS` hard-fails when empty). Deliberate: the variable is repo config the merge itself cannot create, so hard-fail semantics would guarantee a red run for any reusable change landing in the merge→seed window. This matches the `bump-assign-reviewers-callers.yml` precedent (variable created out-of-band, seeded empty). Trade-off: if seeding is forgotten, the fleet no-ops silently — hence the loud follow-up above. - **No `WIRE_BOT_SCRIPT`** — the bot-identity injection (BE-1814) is cursor-review-specific by design (`bump-cursor-review-callers.yml` says it is "set only here"); auto-label callers already pass their own app creds per the reusable's contract. - **`actions/checkout@v6`** (tag, not SHA) — byte-identical to all four sibling bumpers; kept consistent rather than diverging in one file. ## Testing - `shellcheck -x .github/bump-callers/bump-callers.sh .github/bump-callers/tests/test_bump_callers.sh` — clean - `bash .github/bump-callers/tests/test_bump_callers.sh` — 100 passed, 0 failed (12 new checks) - `actionlint` on both touched workflows — clean - `python3 .github/agents-md-integrity/check_agents_md.py --root .` — passed (pre-existing CODEOWNERS warning only) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:35:53 +00:00