[PR #61] [MERGED] chore(check-pr-size): remove committed binary from git and ignore it (BE-4057) #72

New issue

Closed

opened 2026-10-26 22:35:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:35:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/61
Author: @mattmillerai
Created: 7/22/2026
Status: ✅ Merged
Merged: 8/4/2026
Merged by: @mattmillerai

Base: main ← Head: matt/be-4057-remove-committed-binary

📝 Commits (2)

78cc2c6 chore(check-pr-size): remove committed binary from git and ignore it (BE-4057)
e9762b7 Merge remote-tracking branch 'origin/main' into matt/be-4057-remove-committed-binary

📄 Description

ELI-5

A big compiled program file (3.4MB) was accidentally saved into this repo's history — like accidentally stapling a printed photocopy into a recipe book when the recipe itself is already there. Nobody uses the copy (CI always cooks fresh from the recipe), it makes every download of the repo bigger, and it slowly goes stale. This PR deletes the copy and adds a note telling git to never save it again.

What

git rm scripts/check-pr-size/check-pr-size — the 3.4MB arm64 Mach-O binary committed in #51 (a local go build ./... drops the binary next to the sources; it got git add -A-ed).
Add scripts/check-pr-size/check-pr-size to the root .gitignore so a local build can never be re-committed.

Why it's safe

Nothing consumes the tracked binary:

pr-size.yml builds the tool from source at run time (go build -o "${RUNNER_TEMP}/check-pr-size" .) — never touches a tracked binary.
Repo-wide grep for scripts/check-pr-size/check-pr-size → zero references outside the deleted file itself.
.gitignore rules never affect tracked files, and this rule is an exact single-file path — it can't mask anything else.

Verification

go test ./... in scripts/check-pr-size — green (this is exactly what the path-filtered test-pr-size.yml CI job runs).
gofmt -l + go vet ./... — clean.
Simulated the workflow build step locally: go build -o /tmp/... . — builds fine.
git check-ignore -v confirms the new rule matches the binary path.

Judgment calls

The ticket said cursor-review.yml also builds the tool — on current main it has no check-pr-size reference at all (stale ticket detail; doesn't change the fix, since the load-bearing claim — nothing consumes the tracked binary — is verified above).
Ticket offered root .gitignore or a new scripts/check-pr-size/.gitignore; chose the existing root one (already present with a Python section) over adding a new file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/61 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 7/22/2026 **Status:** ✅ Merged **Merged:** 8/4/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `matt/be-4057-remove-committed-binary` --- ### 📝 Commits (2) - [`78cc2c6`](https://github.com/Comfy-Org/github-workflows/commit/78cc2c6ce52a7f0874e985cba77dda7755bc7151) chore(check-pr-size): remove committed binary from git and ignore it (BE-4057) - [`e9762b7`](https://github.com/Comfy-Org/github-workflows/commit/e9762b75de31aca56b3ddb53bd81825afcf49a0b) Merge remote-tracking branch 'origin/main' into matt/be-4057-remove-committed-binary ### 📄 Description ## ELI-5 A big compiled program file (3.4MB) was accidentally saved into this repo's history — like accidentally stapling a printed photocopy into a recipe book when the recipe itself is already there. Nobody uses the copy (CI always cooks fresh from the recipe), it makes every download of the repo bigger, and it slowly goes stale. This PR deletes the copy and adds a note telling git to never save it again. ## What - `git rm scripts/check-pr-size/check-pr-size` — the 3.4MB arm64 Mach-O binary committed in #51 (a local `go build ./...` drops the binary next to the sources; it got `git add -A`-ed). - Add `scripts/check-pr-size/check-pr-size` to the root `.gitignore` so a local build can never be re-committed. ## Why it's safe Nothing consumes the tracked binary: - `pr-size.yml` builds the tool from source at run time (`go build -o "${RUNNER_TEMP}/check-pr-size" .`) — never touches a tracked binary. - Repo-wide grep for `scripts/check-pr-size/check-pr-size` → zero references outside the deleted file itself. - `.gitignore` rules never affect tracked files, and this rule is an exact single-file path — it can't mask anything else. ## Verification - `go test ./...` in `scripts/check-pr-size` — green (this is exactly what the path-filtered `test-pr-size.yml` CI job runs). - `gofmt -l` + `go vet ./...` — clean. - Simulated the workflow build step locally: `go build -o /tmp/... .` — builds fine. - `git check-ignore -v` confirms the new rule matches the binary path. ## Judgment calls - The ticket said `cursor-review.yml` also builds the tool — on current `main` it has no `check-pr-size` reference at all (stale ticket detail; doesn't change the fix, since the load-bearing claim — nothing consumes the tracked binary — is verified above). - Ticket offered root `.gitignore` or a new `scripts/check-pr-size/.gitignore`; chose the existing root one (already present with a Python section) over adding a new file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:35:56 +00:00