Comfy-Org/jpcosta-comfy-apps

Fork 0

mirror of https://github.com/Comfy-Org/jpcosta-comfy-apps.git synced 2026-11-05 06:47:20 +00:00

[PR #13] [MERGED] Gap the carousel cards and slide the next one in from outside #14

New issue

Closed

opened 2026-11-04 22:29:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-04 22:29:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/13
Author: @jpcosta-comfy
Created: 10/1/2026
Status: ✅ Merged
Merged: 10/1/2026
Merged by: @cursor[bot]

Base: main ← Head: cursor/slide-gap-enter-8ac0

📝 Commits (1)

940a9ee Separate sliding cards and bring the next one in from off-screen.

📊 Changes

4 files changed (+94 additions, -78 deletions)

View changed files

📝 scripts/self-check.ts (+10 -6)
📝 src/app/globals.css (+1 -1)
📝 src/components/studio.tsx (+69 -61)
📝 src/lib/ease-slide.ts (+14 -10)

📄 Description

JP’s notes on the live slide: the cards were touching, the next card popped into view and only then moved, and the fade was a separate phase from the move.

Merged and checked on https://comfy-api-apps.vercel.app.

Motion

Cards on the track keep a visible gap (32px on a phone, about 131px on a 1440px desktop — wide enough that the neighbor starts outside the browser).
The incoming card is already off-screen when the click happens. It slides in from outside. It does not appear and then start moving.
The outgoing card fades across the same 0.99s ease.slide move. Next still comes from the right, previous from the left.
At rest the active card still fills the page column. Neighbors stay hidden. The browser edge stays a soft fade, not a hard clip.
Footer links are unchanged.

Production mid-slide

Desktop. Gap between the cards, incoming still partly off the right, outgoing about half faded while it is still moving:

Production desktop mid-slide

Mobile:

Production mobile mid-slide

Desktop at rest, one full-width card:

Production desktop at rest

_{To show artifacts inline, enable in settings.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/13 **Author:** [@jpcosta-comfy](https://github.com/jpcosta-comfy) **Created:** 10/1/2026 **Status:** ✅ Merged **Merged:** 10/1/2026 **Merged by:** [@cursor[bot]](https://github.com/apps/cursor) **Base:** `main` ← **Head:** `cursor/slide-gap-enter-8ac0` --- ### 📝 Commits (1) - [`940a9ee`](https://github.com/Comfy-Org/jpcosta-comfy-apps/commit/940a9eecf179e17e4cced67817f18c164b26b34f) Separate sliding cards and bring the next one in from off-screen. ### 📊 Changes **4 files changed** (+94 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `scripts/self-check.ts` (+10 -6) 📝 `src/app/globals.css` (+1 -1) 📝 `src/components/studio.tsx` (+69 -61) 📝 `src/lib/ease-slide.ts` (+14 -10) </details> ### 📄 Description  JP’s notes on the live slide: the cards were touching, the next card popped into view and only then moved, and the fade was a separate phase from the move. Merged and checked on https://comfy-api-apps.vercel.app. ## Motion - Cards on the track keep a visible gap (32px on a phone, about 131px on a 1440px desktop — wide enough that the neighbor starts outside the browser). - The incoming card is already off-screen when the click happens. It slides in from outside. It does not appear and then start moving. - The outgoing card fades across the same 0.99s `ease.slide` move. Next still comes from the right, previous from the left. - At rest the active card still fills the page column. Neighbors stay hidden. The browser edge stays a soft fade, not a hard clip. - Footer links are unchanged. ## Production mid-slide Desktop. Gap between the cards, incoming still partly off the right, outgoing about half faded while it is still moving: [Production desktop mid-slide](https://cursor.com/agents/bc-80673088-d76f-5c4b-b113-f09a5d2f8ac0/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2Fscreenshots%2Fprod-gap-desktop-mid.png) Mobile: [Production mobile mid-slide](https://cursor.com/agents/bc-80673088-d76f-5c4b-b113-f09a5d2f8ac0/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2Fscreenshots%2Fprod-gap-mobile-mid.png) Desktop at rest, one full-width card: [Production desktop at rest](https://cursor.com/agents/bc-80673088-d76f-5c4b-b113-f09a5d2f8ac0/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2Fscreenshots%2Fprod-gap-desktop-rest.png) <sub>To show artifacts inline, <a href="https://cursor.com/dashboard/cloud-agents#my-pull-requests">enable</a> in settings.</sub>  <div><a href="https://cursor.com/agents/bc-80673088-d76f-5c4b-b113-f09a5d2f8ac0?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-80673088-d76f-5c4b-b113-f09a5d2f8ac0&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-04 22:29:04 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/jpcosta-comfy-apps#14

No description provided.

Rows
Columns