[PR #18] [MERGED] Show finished video results even when metadata never loads #16

New issue

Closed

opened 2026-11-04 22:29:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-04 22:29:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/18
Author: @jpcosta-comfy
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @jpcosta-comfy

Base: main ← Head: fix/video-result-measure

📝 Commits (1)

86210e6 Never let video size probing block a finished result.

📊 Changes

1 file changed (+16 additions, -2 deletions)

View changed files

📝 src/components/app-card.tsx (+16 -2)

📄 Description

A finished Open Unboxing/Swap job could stay on 'running' because measureBlob waited on loadedmetadata from a detached

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/18 **Author:** [@jpcosta-comfy](https://github.com/jpcosta-comfy) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@jpcosta-comfy](https://github.com/jpcosta-comfy) **Base:** `main` ← **Head:** `fix/video-result-measure` --- ### 📝 Commits (1) - [`86210e6`](https://github.com/Comfy-Org/jpcosta-comfy-apps/commit/86210e6676cb2cf4875db6d0f9e33b5641239c51) Never let video size probing block a finished result. ### 📊 Changes **1 file changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/components/app-card.tsx` (+16 -2) </details> ### 📄 Description A finished Open Unboxing/Swap job could stay on 'running' because measureBlob waited on loadedmetadata from a detached <video>, which some browsers (Safari/iOS, background tabs) never fire. Adds a 4s timeout, muted/playsInline + load(), and an image timeout. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-04 22:29:06 +00:00