Comfy-Org/rfcs
1
0
Fork 0
mirror of https://github.com/Comfy-Org/rfcs.git synced 2026-11-05 00:17:38 +00:00
Code Issues 7 Projects Packages Wiki Activity

[PR #41] [MERGED] [fix] Prevent JavaScript syntax errors in sync workflow #26

New issue
Closed
opened 2026-10-26 22:01:29 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:01:29 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/rfcs/pull/41
Author: @christian-byrne
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/2/2025
Merged by: @christian-byrne

Base: main ← Head: fix-sync-workflow-syntax-error

📝 Commits (1)

  • d23c0e1 [fix] Prevent JavaScript syntax errors in sync workflow

📊 Changes

1 file changed (+23 additions, -10 deletions)

View changed files

📝 .github/workflows/sync-rfc-discussion.yml (+23 -10)

📄 Description

Fixes syntax errors in the RFC discussion sync workflow that occur when PR titles or RFC content contain special characters like brackets, quotes, or apostrophes.

Problem: The sync workflow was embedding GitHub Actions expressions directly in JavaScript template literals, causing syntax errors when content contained special characters.

Solution: Use environment variables to pass all dynamic content, avoiding template literal conflicts.

This enables the sync workflow to handle any RFC content safely, including edge cases like:

  • Square brackets in PR titles: [feat] Add new feature
  • Apostrophes in content: GitHub's API
  • Any other special JavaScript characters

Testing: After merge, the existing test PR should successfully sync discussion content on future commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/rfcs/pull/41 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/2/2025 **Merged by:** [@christian-byrne](https://github.com/christian-byrne) **Base:** `main` ← **Head:** `fix-sync-workflow-syntax-error` --- ### 📝 Commits (1) - [`d23c0e1`](https://github.com/Comfy-Org/rfcs/commit/d23c0e1fb7175878b0a23d7abce35c7b2366d5b4) [fix] Prevent JavaScript syntax errors in sync workflow ### 📊 Changes **1 file changed** (+23 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/sync-rfc-discussion.yml` (+23 -10) </details> ### 📄 Description Fixes syntax errors in the RFC discussion sync workflow that occur when PR titles or RFC content contain special characters like brackets, quotes, or apostrophes. **Problem:** The sync workflow was embedding GitHub Actions expressions directly in JavaScript template literals, causing syntax errors when content contained special characters. **Solution:** Use environment variables to pass all dynamic content, avoiding template literal conflicts. This enables the sync workflow to handle any RFC content safely, including edge cases like: - Square brackets in PR titles: `[feat] Add new feature` - Apostrophes in content: `GitHub's API` - Any other special JavaScript characters **Testing:** After merge, the existing test PR should successfully sync discussion content on future commits. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:01:29 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
subgraph
rfc_02
test-enhanced-rfc-workflow
v3
robinjhuang-patch-1
rh-specs
rfc-vue-component-rendering
rfc-04
rfc_03
dynamic_inputs
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/rfcs#26
No description provided.