Comfy-Org/rfcs
1
0
Fork 0
mirror of https://github.com/Comfy-Org/rfcs.git synced 2026-11-05 00:17:38 +00:00
Code Issues 7 Projects Packages Wiki Activity

[PR #9] [MERGED] RFC: Widget Input Socket #8

New issue
Closed
opened 2026-10-26 22:01:18 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:01:18 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/rfcs/pull/9
Author: @huchenlei
Created: 1/13/2025
Status: ✅ Merged
Merged: 4/6/2025
Merged by: @huchenlei

Base: main ← Head: rfc-04

📝 Commits (8)

  • adf4c8c rfc-04: Widget Input Socket
  • eba1585 Update rfcs/0004-widget-input-socket.md
  • beeaadf Update rfcs/0004-widget-input-socket.md
  • 77664e6 Update rfcs/0004-widget-input-socket.md
  • 5a070ca Update rfcs/0004-widget-input-socket.md
  • 1d7f20e Add grab link example
  • 3d394b8 Update rfcs/0004-widget-input-socket.md
  • bf0fbce Update and rename 0004-widget-input-socket.md to 0003-widget-input-socket.md

📊 Changes

1 file changed (+240 additions, -0 deletions)

View changed files

➕ rfcs/0003-widget-input-socket.md (+240 -0)

📄 Description

Summary

This RFC proposes replacing ComfyUI's current widget-to-socket conversion system with a simpler, more intuitive "widget input socket" design. Instead of requiring users to manually convert widgets to sockets through context menus, widgets will automatically display an input socket when hovered over. This socket behaves like any other input socket - allowing users to drag connections to and from it. When connected, the widget becomes disabled (grayed out) to indicate it's receiving an external input.

This change aims to:

  • Simplify the codebase by removing complex conversion logic
  • Improve usability by making connections more discoverable and intuitive
  • Align with industry standards seen in tools like Blender
  • Reduce the number of clicks needed to make connections
  • Eliminate the need to maintain conversion states in workflow files

The proposal represents a breaking change that would be implemented in v2.0, though existing workflows would continue to function without modification.

Links

Important: Do NOT comment on this PR. Please use the discussion thread linked above to provide feedback, as it provides branched discussions that are easier to follow. This also makes the edit history of the PR clearer.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/rfcs/pull/9 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 4/6/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `rfc-04` --- ### 📝 Commits (8) - [`adf4c8c`](https://github.com/Comfy-Org/rfcs/commit/adf4c8c38de0d7e092eac95d6eda901ca5541140) rfc-04: Widget Input Socket - [`eba1585`](https://github.com/Comfy-Org/rfcs/commit/eba1585922fe6c48b0d387251fc26c950ed26611) Update rfcs/0004-widget-input-socket.md - [`beeaadf`](https://github.com/Comfy-Org/rfcs/commit/beeaadff850f07c384e5637668ad85e5a5807380) Update rfcs/0004-widget-input-socket.md - [`77664e6`](https://github.com/Comfy-Org/rfcs/commit/77664e608be2aa3651c0e0a5a60f8e20c2d8755c) Update rfcs/0004-widget-input-socket.md - [`5a070ca`](https://github.com/Comfy-Org/rfcs/commit/5a070ca5d78dcde605db5af30680e3b0a0a12fb9) Update rfcs/0004-widget-input-socket.md - [`1d7f20e`](https://github.com/Comfy-Org/rfcs/commit/1d7f20e103d54d4cc5851b57ea3b25fd15294574) Add grab link example - [`3d394b8`](https://github.com/Comfy-Org/rfcs/commit/3d394b8f225f0c7303bfa428b2293f3dd07b91ef) Update rfcs/0004-widget-input-socket.md - [`bf0fbce`](https://github.com/Comfy-Org/rfcs/commit/bf0fbce9f275e0a15f5414469ba2692944b4e5c7) Update and rename 0004-widget-input-socket.md to 0003-widget-input-socket.md ### 📊 Changes **1 file changed** (+240 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `rfcs/0003-widget-input-socket.md` (+240 -0) </details> ### 📄 Description ## Summary This RFC proposes replacing ComfyUI's current widget-to-socket conversion system with a simpler, more intuitive "widget input socket" design. Instead of requiring users to manually convert widgets to sockets through context menus, widgets will automatically display an input socket when hovered over. This socket behaves like any other input socket - allowing users to drag connections to and from it. When connected, the widget becomes disabled (grayed out) to indicate it's receiving an external input. This change aims to: - Simplify the codebase by removing complex conversion logic - Improve usability by making connections more discoverable and intuitive - Align with industry standards seen in tools like Blender - Reduce the number of clicks needed to make connections - Eliminate the need to maintain conversion states in workflow files The proposal represents a breaking change that would be implemented in v2.0, though existing workflows would continue to function without modification. ## Links <!-- Both links below will be automatically filled in when you create the PR. You do not need to modify this section. --> - [Full Rendered Proposal](https://github.com/Comfy-Org/rfcs/blob/rfc-04/rfcs/0004-widget-input-socket.md) - [Discussion Thread](https://github.com/Comfy-Org/rfcs/discussions/10) <!-- Optional: Include any additional links to related issues or resources below --> --- **Important: Do NOT comment on this PR. Please use the discussion thread linked above to provide feedback, as it provides branched discussions that are easier to follow. This also makes the edit history of the PR clearer.** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:01:18 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
subgraph
rfc_02
test-enhanced-rfc-workflow
v3
robinjhuang-patch-1
rh-specs
rfc-vue-component-rendering
rfc-04
rfc_03
dynamic_inputs
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/rfcs#8
No description provided.