[PR #12] [MERGED] Audit and harden wheels release target resolution #13

New issue

Closed

opened 2026-10-26 22:02:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:02:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/wheels/pull/12
Author: @pollockjj
Created: 4/17/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @pollockjj

Base: develop ← Head: develop

📝 Commits (10+)

6af1e10 Merge pull request #2 from Comfy-Org/develop
9455e2f Bump actions/upload-artifact from 4.6.2 to 7.0.1
6db29c6 Bump actions/checkout from 4.3.1 to 6.0.2
d20fc98 Bump actions/setup-python from 5.6.0 to 6.2.0
f138df8 Bump actions/download-artifact from 4.3.0 to 8.0.1
3d0d8c0 Bump actions/attest-build-provenance from 3.0.0 to 4.1.0
6c98cd1 fix: route all Windows builds to GitHub-hosted runners — zero self-hosted runners
8523504 Merge pull request #8 from pollockjj/fix/no-selfhosted
168e415 Merge pull request #7 from Comfy-Org/dependabot/github_actions/actions/attest-build-provenance-4.1.0
f77b1c9 Merge pull request #6 from Comfy-Org/dependabot/github_actions/actions/download-artifact-8.0.1

📊 Changes

11 files changed (+209 additions, -143 deletions)

View changed files

📝 .github/workflows/build.yml (+14 -116)
📝 .github/workflows/get-sources.yml (+3 -3)
📝 .github/workflows/inspect-all-wheels.yml (+4 -4)
📝 .github/workflows/update-index.yml (+2 -2)
📝 .github/workflows/validate.yml (+7 -7)
📝 README.md (+1 -1)
📝 scripts/generate_index.py (+16 -2)
📝 scripts/generate_matrix.py (+3 -7)
➕ scripts/release_target.py (+60 -0)
📝 tests/test_generate_index.py (+57 -1)
➕ tests/test_release_target.py (+42 -0)

📄 Description

Summary

remove hard-coded release and install target literals from the wheels workflow and docs
centralize release repo and GitHub Pages index URL resolution in scripts/release_target.py
add resolver coverage and script-execution coverage for generate_index.py

Verification

python3 -m pytest tests/test_generate_index.py tests/test_release_target.py
Windows verification executed on RunningMan against C:\dev_master\wheels with the targeted pytest selection

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/wheels/pull/12 **Author:** [@pollockjj](https://github.com/pollockjj) **Created:** 4/17/2026 **Status:** ✅ Merged **Merged:** 4/17/2026 **Merged by:** [@pollockjj](https://github.com/pollockjj) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`6af1e10`](https://github.com/Comfy-Org/wheels/commit/6af1e102f923b268e54a9e4f4ba4796e372cf9c7) Merge pull request #2 from Comfy-Org/develop - [`9455e2f`](https://github.com/Comfy-Org/wheels/commit/9455e2f948ed544d8eba13a9eda5fa1ba96b6fe2) Bump actions/upload-artifact from 4.6.2 to 7.0.1 - [`6db29c6`](https://github.com/Comfy-Org/wheels/commit/6db29c68fd834d1b40b71c387e1b0a83769eabfc) Bump actions/checkout from 4.3.1 to 6.0.2 - [`d20fc98`](https://github.com/Comfy-Org/wheels/commit/d20fc986af8c3dd34a7f0f9b8abd1d4914c76f90) Bump actions/setup-python from 5.6.0 to 6.2.0 - [`f138df8`](https://github.com/Comfy-Org/wheels/commit/f138df8faed463655a0f7969cd4104551b2d59af) Bump actions/download-artifact from 4.3.0 to 8.0.1 - [`3d0d8c0`](https://github.com/Comfy-Org/wheels/commit/3d0d8c04aa712236204af6a0e20242b78be64571) Bump actions/attest-build-provenance from 3.0.0 to 4.1.0 - [`6c98cd1`](https://github.com/Comfy-Org/wheels/commit/6c98cd1670b2872f87d4959b08b2bda8564d8c35) fix: route all Windows builds to GitHub-hosted runners — zero self-hosted runners - [`8523504`](https://github.com/Comfy-Org/wheels/commit/8523504052c75723726d109566dd3de1b61ac5c5) Merge pull request #8 from pollockjj/fix/no-selfhosted - [`168e415`](https://github.com/Comfy-Org/wheels/commit/168e415b341e38671d596806c3068bcfc1f5f354) Merge pull request #7 from Comfy-Org/dependabot/github_actions/actions/attest-build-provenance-4.1.0 - [`f77b1c9`](https://github.com/Comfy-Org/wheels/commit/f77b1c96eb3b14c0d817cd6e454d0f0e6f313606) Merge pull request #6 from Comfy-Org/dependabot/github_actions/actions/download-artifact-8.0.1 ### 📊 Changes **11 files changed** (+209 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+14 -116) 📝 `.github/workflows/get-sources.yml` (+3 -3) 📝 `.github/workflows/inspect-all-wheels.yml` (+4 -4) 📝 `.github/workflows/update-index.yml` (+2 -2) 📝 `.github/workflows/validate.yml` (+7 -7) 📝 `README.md` (+1 -1) 📝 `scripts/generate_index.py` (+16 -2) 📝 `scripts/generate_matrix.py` (+3 -7) ➕ `scripts/release_target.py` (+60 -0) 📝 `tests/test_generate_index.py` (+57 -1) ➕ `tests/test_release_target.py` (+42 -0) </details> ### 📄 Description ## Summary - remove hard-coded release and install target literals from the wheels workflow and docs - centralize release repo and GitHub Pages index URL resolution in `scripts/release_target.py` - add resolver coverage and script-execution coverage for `generate_index.py` ## Verification - python3 -m pytest tests/test_generate_index.py tests/test_release_target.py - Windows verification executed on RunningMan against `C:\dev_master\wheels` with the targeted pytest selection --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:02:19 +00:00