mirror of
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete.git
synced 2026-11-05 00:17:25 +00:00
[GH-ISSUE #168] Follow symlinks #121
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
low priority
low priority
pull-request
question
waiting for feedback
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DominikDoom/a1111-sd-webui-tagcomplete#121
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @catboxanon on GitHub (May 3, 2023).
Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/168
The web UI currently reads all extra networks recursively and follows symlinks, something the
globmodule supports but I don't believepathlibdoes yet. This can be verified by symlinking a directory, and comparing the list in the extra networks list compared to those returned by tagcomplete. A few examples here:github.com/AUTOMATIC1111/stable-diffusion-webui@5ab7f213be/extensions-builtin/Lora/lora.py (L349-L352)github.com/AUTOMATIC1111/stable-diffusion-webui@5ab7f213be/modules/hypernetworks/hypernetwork.py (L315)I know Gradio is pretty restrictive about anything outside of working directory, but I imagine if the extra networks list can read them fine then extensions could too.
@DominikDoom commented on GitHub (May 3, 2023):
True, the Gradio restrictions only apply to the client side, so if the JavaScript part wants to load something. This isn't a problem for the list of hypernets and lora since they are written to a temp file. Only when those temp files are outside the root (so when the extensions dir itself is symlinked) there are problems.
I changed it to use glob similar to the webui implementation like you suggested, so it should follow them now.
@catboxanon commented on GitHub (May 3, 2023):
Works now, thanks!