[PR #21] [MERGED] Some performance optimizations #242

New issue

Closed

opened 2026-10-30 21:21:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-30 21:21:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/21
Author: @sgmklp
Created: 10/18/2022
Status: ✅ Merged
Merged: 10/18/2022
Merged by: @DominikDoom

Base: main ← Head: dev

📝 Commits (10+)

98f3617 add a logic change
8b8656f put special Tag before normal Tags
9169c46 put special Tag before normal Tags
df51f67 Merge branch 'logic_changes' of https://github.com/sgmklp/a1111-sd-webui-tagcomplete into logic_changes
c079fd5 .
fae269c Merge branch 'dev' into logic_changes
c18f5a4 Merge branch 'dev' into logic_changes
17ca9c0 add README_ZH.md
5073616 finish README_ZH.md for last version
f6c5064 .

📊 Changes

2 files changed (+64 additions, -48 deletions)

View changed files

📝 javascript/tagAutocomplete.js (+63 -48)
📝 tags/config.json (+1 -0)

📄 Description

There are four major changes to this branch:
1.The logic when adding the element of the result list is not very clear. I have made it clearer and the function is the same as before.
2.When the number of results is too large, the selection of results will not be smooth. I solved this problem using indexes. (Because only one result will be selected, there is no need to use a loop)
3.Change the global variables not defined by var to var, so as to use the "Go to Definition" function of IDE such as VS CODE.
4.When the number of results is too large, it took too long to load the result list. At first, only part of the results will be loaded, and then part of the results will be loaded when the last result is reached.The config option resultStepLength can set the number of everytime load.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/21 **Author:** [@sgmklp](https://github.com/sgmklp) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 10/18/2022 **Merged by:** [@DominikDoom](https://github.com/DominikDoom) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (10+) - [`98f3617`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/98f3617292b2477171a6023e3fb973b1cf664d0f) add a logic change - [`8b8656f`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/8b8656f13e86fec3f4241b17c292af9fca65b964) put special Tag before normal Tags - [`9169c46`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/9169c461dacd96f9185f99dbab2ebca424c72c4d) put special Tag before normal Tags - [`df51f67`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/df51f673619970932f7ec2a99e01101ae161f137) Merge branch 'logic_changes' of https://github.com/sgmklp/a1111-sd-webui-tagcomplete into logic_changes - [`c079fd5`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/c079fd514db025818bdde51a9b70479d0201ea54) . - [`fae269c`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/fae269c46dc9ff0820d4a90106992da5ed9019b2) Merge branch 'dev' into logic_changes - [`c18f5a4`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/c18f5a4a4aa2168f66ad62bcb34df88ce1a37f1d) Merge branch 'dev' into logic_changes - [`17ca9c0`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/17ca9c0c1af9c9811322ee68d108a25e6b336b6e) add README_ZH.md - [`5073616`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/5073616fc52252f7159cd757b3c1996056808868) finish README_ZH.md for last version - [`f6c5064`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/f6c5064c8c10c85f46c16cf3972089d4875a33be) . ### 📊 Changes **2 files changed** (+64 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `javascript/tagAutocomplete.js` (+63 -48) 📝 `tags/config.json` (+1 -0) </details> ### 📄 Description There are four major changes to this branch: 1.The logic when adding the element of the result list is not very clear. I have made it clearer and the function is the same as before. 2.When the number of results is too large, the selection of results will not be smooth. I solved this problem using indexes. (Because only one result will be selected, there is no need to use a loop) 3.Change the global variables not defined by var to var, so as to use the "Go to Definition" function of IDE such as VS CODE. 4.When the number of results is too large, it took too long to load the result list. At first, only part of the results will be loaded, and then part of the results will be loaded when the last result is reached.The config option `resultStepLength` can set the number of everytime load. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-30 21:21:36 +00:00