[PR #306] [MERGED] Underscore replacement exclusion list feature #297

Closed
opened 2026-10-30 21:22:07 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/306
Author: @david419kr
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @DominikDoom

Base: main ← Head: main


📝 Commits (2)

  • 3271a30 added underscore replacemente exclusion list feature
  • 3f0fa27 removed needs_restart

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 javascript/tagAutocomplete.js (+7 -2)
📝 scripts/tag_autocomplete_helper.py (+1 -0)

📄 Description

image

While I'm not entirely certain if this feature is necessary, I personally felt it would be useful, so I decided to implement it.

Some facial expression tags in Danbooru contain underscores that shouldn't be converted to spaces, and I found it cumbersome to manually change spaces back to underscores during auto-completion. So I added a blacklist feature to address this issue.

I got the idea from a similar feature in the Tagger extension.

Can add items to the list as comma-separated strings in the webui settings.

If you find this suitable, I would appreciate your consideration for merging.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/306 **Author:** [@david419kr](https://github.com/david419kr) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@DominikDoom](https://github.com/DominikDoom) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`3271a30`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/3271a306eaa8605398aab6af0b047e46f6111db8) added underscore replacemente exclusion list feature - [`3f0fa27`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/3f0fa275f3bf11af628ac290787d51ba73197c9d) removed needs_restart ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `javascript/tagAutocomplete.js` (+7 -2) 📝 `scripts/tag_autocomplete_helper.py` (+1 -0) </details> ### 📄 Description ![image](https://github.com/user-attachments/assets/910352af-0134-47c7-8597-c70143548529) While I'm not entirely certain if this feature is necessary, I personally felt it would be useful, so I decided to implement it. Some facial expression tags in Danbooru contain underscores that shouldn't be converted to spaces, and I found it cumbersome to manually change spaces back to underscores during auto-completion. So I added a blacklist feature to address this issue. I got the idea from a similar feature in the Tagger extension. Can add items to the list as comma-separated strings in the webui settings. If you find this suitable, I would appreciate your consideration for merging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-30 21:22:07 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DominikDoom/a1111-sd-webui-tagcomplete#297
No description provided.