[GH-ISSUE #48] Broken with correct parenthesis #39

New issue

Closed

opened 2026-10-30 21:17:41 +00:00 by bsakaguchi · 5 comments

bsakaguchi commented

2026-10-30 21:17:41 +00:00

Owner

Originally created by @byzod on GitHub (Oct 29, 2022).
Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/48

It's even working with very wrong syntax, but a simple parenthesis breaks it with the latest version a038664616 🤔

error in js console

Uncaught (in promise) TypeError: can't access property "style", y is null
    k http://127.0.0.1:7860/assets/index.6d1e8daf.js line 1704 > srcScript:1
3 [index.6d1e8daf.js line 1704 > srcScript:1:2468](http://127.0.0.1:7860/assets/index.6d1e8daf.js%20line%201704%20%3E%20srcScript)

Uncaught (in promise) TypeError: can't access property "length", x[2] is undefined
    tags http://127.0.0.1:7860/:2028
    autocomplete http://127.0.0.1:7860/:2028
    <anonymous> http://127.0.0.1:7860/:2343
    dbTimeOut http://127.0.0.1:7860/:1752
11 [127.0.0.1:7860:2028:26](http://127.0.0.1:7860/)

Originally created by @byzod on GitHub (Oct 29, 2022). Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/48 It's even working with very wrong syntax, but a simple parenthesis breaks it with the latest version a038664616b7a8258ca80a10c1c1ae3595ee68a9 🤔 ![An1](https://user-images.githubusercontent.com/848607/198838996-e4922e85-7a6b-4289-9be5-863f849062ab.gif) error in js console ![1](https://user-images.githubusercontent.com/848607/198839064-b18ef3ea-fe66-4714-b7d4-305398f99543.jpg) ``` Uncaught (in promise) TypeError: can't access property "style", y is null k http://127.0.0.1:7860/assets/index.6d1e8daf.js line 1704 > srcScript:1 3 [index.6d1e8daf.js line 1704 > srcScript:1:2468](http://127.0.0.1:7860/assets/index.6d1e8daf.js%20line%201704%20%3E%20srcScript) Uncaught (in promise) TypeError: can't access property "length", x[2] is undefined tags http://127.0.0.1:7860/:2028 autocomplete http://127.0.0.1:7860/:2028 <anonymous> http://127.0.0.1:7860/:2343 dbTimeOut http://127.0.0.1:7860/:1752 11 [127.0.0.1:7860:2028:26](http://127.0.0.1:7860/) ```

bsakaguchi closed this issue

2026-10-30 21:17:41 +00:00

bsakaguchi commented

2026-10-30 21:17:42 +00:00

Author

Owner

@DominikDoom commented on GitHub (Oct 29, 2022):

Huh, looks like I broke something while fixing the embeds.
Thanks for the report, I'll try to fix it asap

@DominikDoom commented on GitHub (Oct 29, 2022): Huh, looks like I broke something while fixing the embeds. Thanks for the report, I'll try to fix it asap

bsakaguchi commented

2026-10-30 21:17:42 +00:00

Author

Owner

@DominikDoom commented on GitHub (Oct 29, 2022):

Sorry for the inconvenience, it was a stupid oversight on my part.
I just forgot to add a check if x[2] (the generic match) even existed, which broke it for the parentheses.
Should be fixed now.

@DominikDoom commented on GitHub (Oct 29, 2022): Sorry for the inconvenience, it was a stupid oversight on my part. I just forgot to add a check if x[2] (the generic match) even existed, which broke it for the parentheses. Should be fixed now.

bsakaguchi commented

2026-10-30 21:17:42 +00:00

Author

Owner

@byzod commented on GitHub (Oct 29, 2022):

It's working now but have a small difference

The first tag complete list show on input of the first character, but every tag after the first will only show on input of the second characters

Is this change intentional?

@byzod commented on GitHub (Oct 29, 2022): It's working now but have a small difference The first tag complete list show on input of the first character, but every tag after the first will only show on input of the second characters Is this change intentional? ![An1](https://user-images.githubusercontent.com/848607/198840715-7b55cbb3-2669-4adb-8e22-ff4a33254bd2.gif)

bsakaguchi commented

2026-10-30 21:17:42 +00:00

Author

Owner

@DominikDoom commented on GitHub (Oct 29, 2022):

Not intentional, seems like there still is a small regex issue. I'll try figuring it out.

@DominikDoom commented on GitHub (Oct 29, 2022): Not intentional, seems like there still is a small regex issue. I'll try figuring it out.

bsakaguchi commented

2026-10-30 21:17:43 +00:00

Author

Owner

@DominikDoom commented on GitHub (Oct 29, 2022):

Typical JavaScript bug, I checked for null but unmatched regex groups are specified as undefined. Hopefully fixed for real this time.

@DominikDoom commented on GitHub (Oct 29, 2022): Typical JavaScript bug, I checked for `null` but unmatched regex groups are specified as `undefined`. Hopefully fixed for real this time.