mirror of
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete.git
synced 2026-11-05 00:17:25 +00:00
[GH-ISSUE #51] Can't autocomplete Chinese characters #40
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
low priority
low priority
pull-request
question
waiting for feedback
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DominikDoom/a1111-sd-webui-tagcomplete#40
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @liggest on GitHub (Oct 30, 2022).
Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/51
Originally assigned to: @DominikDoom on GitHub.
Normally, the tag autocomplete works perfectly


examples below use the word ninja (忍者)
But autocomplete dosen't show up after stop inputting Chinese characters
Generally, Chinese native speakers use some kinds of input methods (or 输入法) as an assistance to input Chinese characters
After typing alphabet representations, one could choose right characters by pressing number keys or space (for current choice) or enter(for reserving inputted alphabets)
As shown above, autocomplete dosen't seem to work in these kinds of occasions. I vaguely remember that it was working few versions ago, but I'm not sure about how to test again
In additional, autocomplete for deleting seems to have similar problem


@DominikDoom commented on GitHub (Oct 30, 2022):
I don't have a Chinese IME installed so I can't test it at the moment, but I'll try it out later if I have time.
If you want to try out older versions to see where it stopped working, you can find them in https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/releases. That would definitely be helpful.
Also please check if searchByTranslation is true in your config, that should be the only relevant option.
@liggest commented on GitHub (Oct 30, 2022):
It's true by default, and I haven't changed it
Thanks for providing this, it helps a lot. Maybe I'll try them later
@DominikDoom commented on GitHub (Oct 30, 2022):
I just had a look in the code again and am pretty sure I found the issue, before 1.9.0 should work.
I will fix it later today. It's related to the updated regex after 1.9.0 not correctly matching words starting with non-ascii characters.
@liggest commented on GitHub (Oct 30, 2022):
I've just tried version hotfix 1.8.2, it works for me, so I think you're right
Thanks for updating so quickly!