[GH-ISSUE #62] Translation not working #47

New issue

Closed

opened 2026-10-30 21:17:50 +00:00 by bsakaguchi · 7 comments

bsakaguchi commented 2026-10-30 21:17:50 +00:00

Owner

Copy link

Originally created by @byzod on GitHub (Nov 4, 2022).
Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/62

1. Download github.com/DominikDoom/a1111-sd-webui-tagcomplete@82355cdb60 as zip, extract to sd webui's extension folder \extensions\tag-complete\
2. Create test.csv with content below and save with UTF-8 encoding, place it into \extensions\tag-complete\tags\

   solo,0,单人
   

3. Change line 24 of \extensions\tag-complete\tags\config.json from "extraFile": "", to "extraFile": "test.csv",
4. Launch sd webui and wait for tagcomplete loaded, then type sol in prompt textbox

Expected result:

Actual result:

Originally created by @byzod on GitHub (Nov 4, 2022). Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/62 1. Download https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/82355cdb608c4acc5a42ace2079916ddd9b63576 as zip, extract to sd webui's extension folder `\extensions\tag-complete\` 2. Create `test.csv` with content below and save with UTF-8 encoding, place it into `\extensions\tag-complete\tags\` ``` solo,0,单人 ``` 4. Change line 24 of `\extensions\tag-complete\tags\config.json` from `"extraFile": "",` to `"extraFile": "test.csv",` 5. Launch sd webui and wait for tagcomplete loaded, then type `sol` in prompt textbox ### Expected result:  ### Actual result: 

bsakaguchi closed this issue 2026-10-30 21:17:50 +00:00

bsakaguchi commented 2026-10-30 21:17:51 +00:00

Author

Owner

Copy link

@DominikDoom commented on GitHub (Nov 4, 2022):

The translations will only show if you search by the translated term, just with the rest of the aliases.
So in case of this example, it will show when typing a part of 单人.

I can't really have an "always show" option since a tag often has multiple aliases, so there's no way to choose which one to display in that case (except maybe defaulting to the first/last). And I also don't want to add a completely separate field for translation in the csv since aliases and translations are functionally the same.

Is this a big issue? I was under the impression that you would only use the translations by typing the translated term in the first place.

<!-- gh-comment-id:1303896280 --> @DominikDoom commented on GitHub (Nov 4, 2022): The translations will only show if you search by the translated term, just with the rest of the aliases. So in case of this example, it will show when typing a part of 单人. I can't really have an "always show" option since a tag often has multiple aliases, so there's no way to choose which one to display in that case (except maybe defaulting to the first/last). And I also don't want to add a completely separate field for translation in the csv since aliases and translations are functionally the same. Is this a big issue? I was under the impression that you would only use the translations by typing the translated term in the first place.

bsakaguchi commented 2026-10-30 21:17:51 +00:00

Author

Owner

Copy link

@byzod commented on GitHub (Nov 5, 2022):

The translations will only show if you search by the translated term, just with the rest of the aliases. So in case of this example, it will show when typing a part of 单人.

I can't really have an "always show" option since a tag often has multiple aliases, so there's no way to choose which one to display in that case (except maybe defaulting to the first/last). And I also don't want to add a completely separate field for translation in the csv since aliases and translations are functionally the same.

Is this a big issue? I was under the impression that you would only use the translations by typing the translated term in the first place.

Yes, it's a game changer. Searching english words while displaying translation is the main feature required for non-english speakers, just like the main input box for English-Chinese translation requires you type english words, not the contrary. Or like physical english dictionaries, there're no dictionaries indexed by Chinese words

Search Chinese to find english result is an excellent additional feature but not essential. Just like chinese-english translation, they have different purpose and can't replace each other's role

I suppose that different implementation of alias and translation is required, they're not exact the same thing

Translation with alias could possible looks like this:

or this:

(by using ruby text)

<!-- gh-comment-id:1304398802 --> @byzod commented on GitHub (Nov 5, 2022): > The translations will only show if you search by the translated term, just with the rest of the aliases. So in case of this example, it will show when typing a part of 单人. > > I can't really have an "always show" option since a tag often has multiple aliases, so there's no way to choose which one to display in that case (except maybe defaulting to the first/last). And I also don't want to add a completely separate field for translation in the csv since aliases and translations are functionally the same. > > Is this a big issue? I was under the impression that you would only use the translations by typing the translated term in the first place. Yes, it's a game changer. Searching english words while displaying translation is the main feature required for non-english speakers, just like the main input box for English-Chinese translation requires you type english words, not the contrary. Or like physical english dictionaries, there're no dictionaries indexed by Chinese words Search Chinese to find english result is an excellent additional feature but not essential. Just like chinese-english translation, they have different purpose and can't replace each other's role I suppose that different implementation of alias and translation is required, they're not exact the same thing Translation with alias could possible looks like this:  or this:  (by using [ruby text](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ruby))

bsakaguchi commented 2026-10-30 21:17:51 +00:00

Author

Owner

Copy link

@DominikDoom commented on GitHub (Nov 5, 2022):

I changed it to work like in your first suggestion for now. Translations need to be added in a new separate CSV file, not as an extra file anymore. Default is just two columns with English as first and Translation as second, but I also included a config switch for the old extra format with 3 columns if you use one of those files.
The translations are currently always visible, and are matched purely based on the tag/alias name. Searching by the translated text still works like before if you leave it true in the config.

<!-- gh-comment-id:1304562544 --> @DominikDoom commented on GitHub (Nov 5, 2022): I changed it to work like in your first suggestion for now. Translations need to be added in a new separate CSV file, not as an extra file anymore. Default is just two columns with English as first and Translation as second, but I also included a config switch for the old extra format with 3 columns if you use one of those files. The translations are currently always visible, and are matched purely based on the tag/alias name. Searching by the translated text still works like before if you leave it true in the config.

bsakaguchi commented 2026-10-30 21:17:52 +00:00

Author

Owner

Copy link

@byzod commented on GitHub (Nov 5, 2022):

I changed it to work like in your first suggestion for now. Translations need to be added in a new separate CSV file, not as an extra file anymore. Default is just two columns with English as first and Translation as second, but I also included a config switch for the old extra format with 3 columns if you use one of those files. The translations are currently always visible, and are matched purely based on the tag/alias name. Searching by the translated text still works like before if you leave it true in the config.

Thanks! This is really important for who using it as translate tag helper

<!-- gh-comment-id:1304664878 --> @byzod commented on GitHub (Nov 5, 2022): > I changed it to work like in your first suggestion for now. Translations need to be added in a new separate CSV file, not as an extra file anymore. Default is just two columns with English as first and Translation as second, but I also included a config switch for the old extra format with 3 columns if you use one of those files. The translations are currently always visible, and are matched purely based on the tag/alias name. Searching by the translated text still works like before if you leave it true in the config. Thanks! This is really important for who using it as translate tag helper

bsakaguchi commented 2026-10-30 21:17:52 +00:00

Author

Owner

Copy link

@byzod commented on GitHub (Nov 6, 2022):

@DominikDoom

1. I found that search results by translated text is much lesser than before with the same translation csv, for example searching 袜, every sorts of socks/stocking/thighhighs are displayed, in fact there are 121 hits of 袜 in translation csv
   But after 1.11 I got only 16 results no matter what, even I change resultStepLength to an absurd high value

   demo of searching results of 袜 with github.com/DominikDoom/a1111-sd-webui-tagcomplete@abb5625e55
   

   screenshot of searching results of 袜 with github.com/DominikDoom/a1111-sd-webui-tagcomplete@4eabf00f01, step length 95500
   

2. Strangely, in github.com/DominikDoom/a1111-sd-webui-tagcomplete@4eabf00f01, 美式短袜 (bobby_socks) is in results when searching 短袜 but is not when searching 袜. Few test results: (test done with step length 500 cuz 95500 is too laggy...)

   searching terms	bobby_socks[美式短袜] included in results
   美	Yes
   式	No
   短	No
   袜	No
   美式	Yes
   式短	Yes
   短袜	Yes
   美式短	Yes
   式短袜	Yes
   美式短袜	Yes

Translation and config I use, if it helps (filename with -legacy is for pre-1.10)
cn tags test.zip

p.s. not sure if this is the same problem, should I open a new issue?

<!-- gh-comment-id:1304709484 --> @byzod commented on GitHub (Nov 6, 2022): @DominikDoom 1. I found that search results by translated text is much lesser than before with the same translation csv, for example searching `袜`, every sorts of socks/stocking/thighhighs are displayed, in fact there are 121 hits of `袜` in translation csv But after 1.11 I got only 16 results no matter what, even I change `resultStepLength` to an absurd high value demo of searching results of `袜` with https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/abb5625e55ff07187a8218236cd50691e5c98bb2  screenshot of searching results of `袜` with https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/4eabf00f015b2ddedba98176752dd853678a6f57, step length 95500  2. Strangely, in https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/4eabf00f015b2ddedba98176752dd853678a6f57, `美式短袜` (bobby_socks) is in results when searching `短袜` but is not when searching `袜`. Few test results: (test done with step length 500 cuz 95500 is too laggy...) searching terms | `bobby_socks[美式短袜]` included in results -|- 美 | Yes 式 | **No** 短 | **No** 袜 | **No** 美式 | Yes 式短 | Yes 短袜 | Yes 美式短 | Yes 式短袜 | Yes 美式短袜 | Yes Translation and config I use, if it helps (filename with `-legacy` is for pre-1.10) [cn tags test.zip](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/files/9945123/cn.tags.test.zip) p.s. not sure if this is the same problem, should I open a new issue?

bsakaguchi commented 2026-10-30 21:17:52 +00:00

Author

Owner

Copy link

@DominikDoom commented on GitHub (Nov 6, 2022):

You're right, I tried it with your translation file and it seems to be a bug related to if the searched translation is in the alias, but not the tag itself. The example with bobby_socks is caused because the results with e.g. 式 include tags where this is the case, so the list is cut off on the first tag that fails to match (in this example "ascot").

<!-- gh-comment-id:1304795829 --> @DominikDoom commented on GitHub (Nov 6, 2022): You're right, I tried it with your translation file and it seems to be a bug related to if the searched translation is in the alias, but not the tag itself. The example with bobby_socks is caused because the results with e.g. 式 include tags where this is the case, so the list is cut off on the first tag that fails to match (in this example "ascot").

bsakaguchi commented 2026-10-30 21:17:53 +00:00

Author

Owner

Copy link

@DominikDoom commented on GitHub (Nov 6, 2022):

I think I was already able to fix it, at least I don't see any more cutoff on my side with your test tags.
But feel free to reopen this if you find something that still behaves strange with translations.

<!-- gh-comment-id:1304796753 --> @DominikDoom commented on GitHub (Nov 6, 2022): I think I was already able to fix it, at least I don't see any more cutoff on my side with your test tags. But feel free to reopen this if you find something that still behaves strange with translations.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

refactor-class-scope

feature-fuzzysearch

3.3.0

3.2.0

3.1.0

3.0.0

2.12.0

2.11.0

2.10.6

2.10.5

2.10.1

2.10.0

2.9.0

2.8.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.0

2.5.1

2.5.0

2.4.0

2.3.0

2.2.0

2.1.0

2.0.0

1.17.0

1.16.2

1.16.1

1.16.0

1.15.0

1.14.0

1.13.0

1.12.1

1.12.0

1.11.2

1.11.1

1.11.0

1.10.1

1.10.0

1.9.2

1.9.1

1.9.0

1.8.2

1.8.1

1.8.0

1.7.3

1.7.2

1.7.1

1.7.0

1.6.0

1.5.1

1.5.0

1.4.3

1.4.2

1.4.1

1.4.0

1.3.0

1.2.2

1.2.1

1.2.0

1.1.0

1.0.1

1.0.0

Labels

Clear labels   

bug

  

duplicate

  

enhancement

  

help wanted

  

invalid

  

low priority

  

low priority

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

waiting for feedback

  

wontfix

No labels

bug

duplicate

enhancement

help wanted

invalid

low priority

low priority

pull-request

question

waiting for feedback

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

DominikDoom/a1111-sd-webui-tagcomplete#47

No description provided.