mirror of
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete.git
synced 2026-11-05 00:17:25 +00:00
[GH-ISSUE #71] Feature Request: Move Autocomplete options to Settings #54
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
low priority
low priority
pull-request
question
waiting for feedback
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DominikDoom/a1111-sd-webui-tagcomplete#54
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Evil-Dragon on GitHub (Nov 9, 2022).
Original GitHub issue: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/issues/71
Originally assigned to: @DominikDoom on GitHub.
Would it be possible to move:
To have it's own section the settings page in A111? You could also add the other settings from config.json so that you won't have to edit the file manually.
@DominikDoom commented on GitHub (Nov 9, 2022):
Possible yes, but it's pretty annoying since there is no direct way to access the settings in the javascript part. So I'd have to manually extract them from the settings page HTML as far as I know, which is why I used the extra config file and UI settings so far (if anyone knows a better way, please tell me!).
But I do plan to rework the settings system when I have time, since an edited config can also cause problems with updating the extension using the recently added webui tab, like what was asked about in #70.
@zencyon commented on GitHub (Nov 18, 2022):
could the checkbox setting just be moved a little maybe?
i can see them being handy to have at hand as on/off switches,
but atm they create a huge deadspace area in an already cramped ui, which already makes me consider it not worth it, even if the autocomplete and everything is perfectly cool :)
example: second picture, or a place they don't create deadspace
suggest moving settings somewhere inline, if possible:
@DominikDoom commented on GitHub (Nov 18, 2022):
@zencyon That would be possible as a temporary solution, I only added it down there initially because the inline placement becomes really unpredictable if the user has added more than one setting to the quicksettings bar. As long as I don't have the settings as "real" settings but only as runtime-added controls the user can't control the order of them in the bar for example.
Another temporary option is to hide these options using the config (see #57 and #68), if you're only concerned about the space for now.
@zencyon commented on GitHub (Nov 18, 2022):
@DominikDoom ah, thank you, yes, that help a lot :)
still, having the toggle on/off is nice
don't like restarting webui for it tho, often got several tabs with prompts open
it's not something you use constantly so could be in a less important spot.. can you chose where to place it?
another small spot would be just below the 2 style dropdowns (never use those lol)
@DominikDoom commented on GitHub (Nov 18, 2022):
I'll have a look at it, but since the end goal is to move to real options anyways as soon as I have a bit more time to work on it, a simple inline solution like you said will probably be fine for a while
@DominikDoom commented on GitHub (Nov 20, 2022):
@zencyon I've moved the settings inline for now like you suggested, it should work on all display sizes since the quicksettings bar is using flexbox.
@zencyon commented on GitHub (Nov 20, 2022):
@DominikDoom awesome, i just updated and tried it, cheers <3
cool that it works on various displays too
@byzod commented on GitHub (Nov 22, 2022):
It's worth noting that those spaces are preserved for quick settings
@DominikDoom commented on GitHub (Nov 22, 2022):
@byzod
I know, that's why I said the user won't be able to change the order as long as it isn't added as "real" settings. But they will be added to the end of the quicksettings list just like any other setting, if there's not enough room flexbox will just put them into the next row like the normal settings.
@zencyon commented on GitHub (Nov 22, 2022):
hey @DominikDoom :) been using the addon a fair bit now, it's great
one thing i notice is that sometimes it sort of locks up the keys and get stuck until you pick an option and then correct the word you were typing. In best case scenario i think it should never be blocking the typing in any way
have you experienced this?
(not sure if i should make new issue yet, i haven't found a solid reproduction of the issue yet, it just happens sometimes)
@DominikDoom commented on GitHub (Nov 22, 2022):
@zencyon It shouldn't block normal typing keys, the only keys it captures by default are Up & Down arrows to navigate in the results list and a few related ones like Page Up/Down, Home & End. Left and right arrows aren't used by default, so moving with those to correct typos should always work.
As a side note you can always close the pop-up by pressing Escape. If you can reproduce your issue, feel free to open a separate issue for it, sounds unintended.
@DominikDoom commented on GitHub (Nov 26, 2022):
It was a bit of work as expected, but I finally had the time to complete it. Everything except for the tag colors has moved into the normal settings menu. I wrote about it a bit more detailed in #80, but since it is now based on the webui settings you can add the options to your quicksettings bar if you would like to keep them inline.
The rework also brought some nice quality of life improvements, like reloading tags without restarting the webui and selecting them via dropdown.