[PR #13] [MERGED] Respect when opts.grid_save and/or opts.samples_save are set to false. #25

New issue

Closed

opened 2026-10-30 21:22:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-30 21:22:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Extraltodeus/test_my_prompt/pull/13
Author: @AnonymousCervine
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/5/2023
Merged by: @Extraltodeus

Base: main ← Head: main

📝 Commits (1)

a8bea0a Respect when opts.grid_save and/or opts.samples_save are set to false.

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 test_my_prompt/scripts/test_my_prompt_custom_script.py (+3 -2)

📄 Description

Currently, the script totally disregards the flags opts.samples_save and opts.grid_save ("Always save all generated images" and "Always save all generated image grids" in global settings respectively)

(Well—"totally disregards" is not quite correct for the latter: It currently effectively treats opts.grid_save as an alternative to the scripts own always_grid; either can be set to produce a grid. In which cases it saves the grid anyway, even if opts.grid_save is false. This does not seem like intended behaviour.)

After this fix, the expected behavior should now be:

Individual samples are produced in all cases (as before), but are only saved if opts.samples_save is true.
Grids are produced if either opts.grid_save or always_grid are true (as before), but are only saved if opts.grid_save is true.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Extraltodeus/test_my_prompt/pull/13 **Author:** [@AnonymousCervine](https://github.com/AnonymousCervine) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/5/2023 **Merged by:** [@Extraltodeus](https://github.com/Extraltodeus) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`a8bea0a`](https://github.com/Extraltodeus/test_my_prompt/commit/a8bea0a355618a91f9070e5975af1af40323fe7b) Respect when opts.grid_save and/or opts.samples_save are set to false. ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `test_my_prompt/scripts/test_my_prompt_custom_script.py` (+3 -2) </details> ### 📄 Description Currently, the script totally disregards the flags `opts.samples_save` and `opts.grid_save` ("Always save all generated images" and "Always save all generated image grids" in global settings respectively) (Well—"totally disregards" is not quite correct for the latter: It currently effectively treats `opts.grid_save` as an alternative to the scripts own `always_grid`; either can be set to produce a grid. In which cases it saves the grid anyway, even if `opts.grid_save` is false. This does not seem like intended behaviour.) After this fix, the expected behavior should now be: - Individual samples are produced in all cases (as before), but are only saved if `opts.samples_save` is true. - Grids are *produced* if either `opts.grid_save` or `always_grid` are true (as before), but are only saved if `opts.grid_save` is true. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-30 21:22:41 +00:00