[PR #15] [MERGED] Made grid save options more comprehensive. #27

New issue

Closed

opened 2026-10-30 21:22:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-30 21:22:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Extraltodeus/test_my_prompt/pull/15
Author: @AnonymousCervine
Created: 1/5/2023
Status: ✅ Merged
Merged: 1/6/2023
Merged by: @Extraltodeus

Base: main ← Head: main

📝 Commits (2)

e9d03da Made grid save options more comprehensive.
e1be3dc Fixed unfortunate placement of statement.

📊 Changes

1 file changed (+18 additions, -6 deletions)

View changed files

📝 test_my_prompt/scripts/test_my_prompt_custom_script.py (+18 -6)

📄 Description

Follow-up of discussion in #13

Upon consideration, I have also tentatively added one more option, "Use user settings", for anyone who really wants this to be governed by their global settings. However: I'm not at all certain about it, it may overcomplicate things and it might for instance be better to ignore user settings completely rather than selectively override them (for most people, the desire for a grid here would seem to quite separable from whether they would normally desire one; thus for instance the need for your original flag); there is a balance between "covering all use cases" and "having a minimal interface" and I'm not sure whether this hits the sweet spot.

Let me know what you think.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Extraltodeus/test_my_prompt/pull/15 **Author:** [@AnonymousCervine](https://github.com/AnonymousCervine) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 1/6/2023 **Merged by:** [@Extraltodeus](https://github.com/Extraltodeus) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`e9d03da`](https://github.com/Extraltodeus/test_my_prompt/commit/e9d03dab18f48d97366718864b45446126a78997) Made grid save options more comprehensive. - [`e1be3dc`](https://github.com/Extraltodeus/test_my_prompt/commit/e1be3dcbdd2dae8c599e61df84696f02db61c9c1) Fixed unfortunate placement of statement. ### 📊 Changes **1 file changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `test_my_prompt/scripts/test_my_prompt_custom_script.py` (+18 -6) </details> ### 📄 Description Follow-up of discussion in #13 Upon consideration, I have also tentatively added one more option, "Use user settings", for anyone who really wants this to be governed by their global settings. However: I'm not at all certain about it, it may overcomplicate things and it might for instance be better to ignore user settings completely rather than selectively override them (for most people, the desire for a grid here would seem to quite separable from whether they would normally desire one; thus for instance the need for your original flag); there is a balance between "covering all use cases" and "having a minimal interface" and I'm not sure whether this hits the sweet spot. Let me know what you think. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-30 21:22:42 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Extraltodeus/test_my_prompt#27

No description provided.

Rows
Columns