From 109449438b725a4a617275340d9fd7c3dc7b43f8 Mon Sep 17 00:00:00 2001 From: Allison Piper Date: Tue, 15 Apr 2025 20:33:06 +0000 Subject: [PATCH] Use the new(ish) PREFIX option of rapids-cmake version, git revision header utils. Generate macros prefixed with NVBENCH instead of redefining them from NVBench. --- cmake/NVBenchRapidsCMake.cmake | 5 ++++- nvbench/CMakeLists.txt | 1 + nvbench/git_revision.cuh | 9 +-------- nvbench/version.cuh | 6 +----- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/cmake/NVBenchRapidsCMake.cmake b/cmake/NVBenchRapidsCMake.cmake index 150e6b9..4d16f10 100644 --- a/cmake/NVBenchRapidsCMake.cmake +++ b/cmake/NVBenchRapidsCMake.cmake @@ -20,6 +20,9 @@ endmacro() # Called after project(...) macro(nvbench_init_rapids_cmake) rapids_cmake_build_type(Release) - rapids_cmake_write_version_file("${NVBench_BINARY_DIR}/nvbench/detail/version.cuh") + rapids_cmake_write_version_file( + "${NVBench_BINARY_DIR}/nvbench/detail/version.cuh" + PREFIX "NVBENCH" + ) rapids_cpm_init() endmacro() diff --git a/nvbench/CMakeLists.txt b/nvbench/CMakeLists.txt index 89ac7ed..1c2fb7a 100644 --- a/nvbench/CMakeLists.txt +++ b/nvbench/CMakeLists.txt @@ -139,6 +139,7 @@ endif() rapids_cmake_write_git_revision_file( nvbench_git_revision "${NVBench_BINARY_DIR}/nvbench/detail/git_revision.cuh" + PREFIX "NVBENCH" ) target_link_libraries(nvbench PRIVATE nvbench_git_revision) diff --git a/nvbench/git_revision.cuh b/nvbench/git_revision.cuh index 50fc9da..3aeeb45 100644 --- a/nvbench/git_revision.cuh +++ b/nvbench/git_revision.cuh @@ -18,12 +18,5 @@ #pragma once +// Include the auto-generated git revision header: #include - -// WAR issue rapidsai/rapids-cmake#99: -#define NVBENCH_GIT_BRANCH NVBench_GIT_BRANCH -#define NVBENCH_GIT_SHA1 NVBench_GIT_SHA1 -#define NVBENCH_GIT_VERSION NVBench_GIT_VERSION -#ifdef NVBench_GIT_IS_DIRTY -#define NVBENCH_GIT_IS_DIRTY -#endif diff --git a/nvbench/version.cuh b/nvbench/version.cuh index 69e92e5..02d0d80 100644 --- a/nvbench/version.cuh +++ b/nvbench/version.cuh @@ -18,13 +18,9 @@ #pragma once +// Include the auto-generated version header: #include -// WAR issue rapidsai/rapids-cmake#99 -#define NVBENCH_VERSION_MAJOR NVBench_VERSION_MAJOR -#define NVBENCH_VERSION_MINOR NVBench_VERSION_MINOR -#define NVBENCH_VERSION_PATCH NVBench_VERSION_PATCH - // clang-format off /// Numeric version as "MMmmpp"