From e7a4ce70dc4cd2d281fab2bc14d3616f3664d15d Mon Sep 17 00:00:00 2001 From: Andre Maximo Date: Fri, 1 Sep 2023 14:23:14 -0300 Subject: [PATCH] fix: add final mark in do_clone methods to avoid warnings --- nvbench/float64_axis.cuh | 2 +- nvbench/int64_axis.cuh | 2 +- nvbench/string_axis.cuh | 2 +- nvbench/type_axis.cuh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/nvbench/float64_axis.cuh b/nvbench/float64_axis.cuh index 947b581..ef7b089 100644 --- a/nvbench/float64_axis.cuh +++ b/nvbench/float64_axis.cuh @@ -40,7 +40,7 @@ struct float64_axis final : public axis_base [[nodiscard]] nvbench::float64_t get_value(std::size_t i) const { return m_values[i]; } private: - std::unique_ptr do_clone() const { return std::make_unique(*this); } + std::unique_ptr do_clone() const final { return std::make_unique(*this); } std::size_t do_get_size() const final { return m_values.size(); } std::string do_get_input_string(std::size_t i) const final; std::string do_get_description(std::size_t i) const final; diff --git a/nvbench/int64_axis.cuh b/nvbench/int64_axis.cuh index baa7641..4df35c9 100644 --- a/nvbench/int64_axis.cuh +++ b/nvbench/int64_axis.cuh @@ -85,7 +85,7 @@ struct int64_axis final : public axis_base }; private: - std::unique_ptr do_clone() const { return std::make_unique(*this); } + std::unique_ptr do_clone() const final { return std::make_unique(*this); } std::size_t do_get_size() const final { return m_inputs.size(); } std::string do_get_input_string(std::size_t) const final; std::string do_get_description(std::size_t) const final; diff --git a/nvbench/string_axis.cuh b/nvbench/string_axis.cuh index a4e8c62..a8af16e 100644 --- a/nvbench/string_axis.cuh +++ b/nvbench/string_axis.cuh @@ -40,7 +40,7 @@ struct string_axis final : public axis_base [[nodiscard]] const std::string &get_value(std::size_t i) const { return m_values[i]; } private: - std::unique_ptr do_clone() const { return std::make_unique(*this); } + std::unique_ptr do_clone() const final { return std::make_unique(*this); } std::size_t do_get_size() const final { return m_values.size(); } std::string do_get_input_string(std::size_t i) const final { return m_values[i]; } std::string do_get_description(std::size_t) const final { return {}; } diff --git a/nvbench/type_axis.cuh b/nvbench/type_axis.cuh index 27c1cc1..3a4c59a 100644 --- a/nvbench/type_axis.cuh +++ b/nvbench/type_axis.cuh @@ -60,7 +60,7 @@ struct type_axis final : public axis_base [[nodiscard]] std::size_t get_type_index(const std::string &input_string) const; private: - std::unique_ptr do_clone() const { return std::make_unique(*this); } + std::unique_ptr do_clone() const final { return std::make_unique(*this); } std::size_t do_get_size() const final { return m_input_strings.size(); } std::string do_get_input_string(std::size_t i) const final { return m_input_strings[i]; } std::string do_get_description(std::size_t i) const final { return m_descriptions[i]; }