From 943f268280e18a9def079d288e2651c3ca2c12fc Mon Sep 17 00:00:00 2001 From: Allison Piper Date: Fri, 5 Apr 2024 18:18:33 +0000 Subject: [PATCH] Fix warnings with clang host compiler. --- examples/axes.cu | 7 +++++-- examples/custom_criterion.cu | 3 ++- examples/exec_tag_timer.cu | 2 ++ examples/stream.cu | 1 + examples/throughput.cu | 1 + nvbench/detail/measure_cold.cu | 4 ++-- testing/axes_metadata.cu | 2 +- testing/stdrel_criterion.cu | 8 ++++---- 8 files changed, 18 insertions(+), 10 deletions(-) diff --git a/examples/axes.cu b/examples/axes.cu index c1c0f2b..44ae598 100644 --- a/examples/axes.cu +++ b/examples/axes.cu @@ -56,8 +56,8 @@ NVBENCH_BENCH(single_float64_axis) void copy_sweep_grid_shape(nvbench::state &state) { // Get current parameters: - const int block_size = static_cast(state.get_int64("BlockSize")); - const int num_blocks = static_cast(state.get_int64("NumBlocks")); + const auto block_size = static_cast(state.get_int64("BlockSize")); + const auto num_blocks = static_cast(state.get_int64("NumBlocks")); // Number of int32s in 256 MiB: const std::size_t num_values = 256 * 1024 * 1024 / sizeof(nvbench::int32_t); @@ -77,6 +77,7 @@ void copy_sweep_grid_shape(nvbench::state &state) num_values, in_ptr = thrust::raw_pointer_cast(in.data()), out_ptr = thrust::raw_pointer_cast(out.data())](nvbench::launch &launch) { + (void) num_values; // clang thinks this is unused... nvbench::copy_kernel<<>>( in_ptr, out_ptr, @@ -110,6 +111,7 @@ void copy_type_sweep(nvbench::state &state, nvbench::type_list) [num_values, in_ptr = thrust::raw_pointer_cast(in.data()), out_ptr = thrust::raw_pointer_cast(out.data())](nvbench::launch &launch) { + (void) num_values; // clang thinks this is unused... nvbench::copy_kernel<<<256, 256, 0, launch.get_stream()>>>(in_ptr, out_ptr, num_values); @@ -156,6 +158,7 @@ void copy_type_conversion_sweep(nvbench::state &state, [num_values, in_ptr = thrust::raw_pointer_cast(in.data()), out_ptr = thrust::raw_pointer_cast(out.data())](nvbench::launch &launch) { + (void) num_values; // clang thinks this is unused... nvbench::copy_kernel<<<256, 256, 0, launch.get_stream()>>>(in_ptr, out_ptr, num_values); diff --git a/examples/custom_criterion.cu b/examples/custom_criterion.cu index 4dbee9e..4661235 100644 --- a/examples/custom_criterion.cu +++ b/examples/custom_criterion.cu @@ -36,7 +36,7 @@ public: protected: // Setup the criterion in the `do_initialize()` method: - virtual void do_initialize() override + virtual void do_initialize() override { m_num_samples = 0; } @@ -71,6 +71,7 @@ void throughput_bench(nvbench::state &state) state.add_global_memory_writes(num_values); state.exec(nvbench::exec_tag::no_batch, [&input, &output, num_values](nvbench::launch &launch) { + (void) num_values; // clang thinks this is unused... nvbench::copy_kernel<<<256, 256, 0, launch.get_stream()>>>( thrust::raw_pointer_cast(input.data()), thrust::raw_pointer_cast(output.data()), diff --git a/examples/exec_tag_timer.cu b/examples/exec_tag_timer.cu index 812dda8..e283f43 100644 --- a/examples/exec_tag_timer.cu +++ b/examples/exec_tag_timer.cu @@ -54,6 +54,8 @@ void mod2_inplace(nvbench::state &state) state.exec(nvbench::exec_tag::timer, // Lambda now takes a `timer` argument: [&input, &data, num_values](nvbench::launch &launch, auto &timer) { + (void) num_values; // clang thinks this is unused... + // Reset working data: thrust::copy(thrust::device.on(launch.get_stream()), input.cbegin(), diff --git a/examples/stream.cu b/examples/stream.cu index 9507558..20254e5 100644 --- a/examples/stream.cu +++ b/examples/stream.cu @@ -52,6 +52,7 @@ void stream_bench(nvbench::state &state) state.set_cuda_stream(nvbench::make_cuda_stream_view(default_stream)); state.exec([&input, &output, num_values](nvbench::launch &) { + (void) num_values; // clang thinks this is unused... copy(thrust::raw_pointer_cast(input.data()), thrust::raw_pointer_cast(output.data()), num_values); diff --git a/examples/throughput.cu b/examples/throughput.cu index 5621ebd..24df6ee 100644 --- a/examples/throughput.cu +++ b/examples/throughput.cu @@ -51,6 +51,7 @@ void throughput_bench(nvbench::state &state) state.add_global_memory_writes(num_values); state.exec([&input, &output, num_values](nvbench::launch &launch) { + (void) num_values; // clang thinks this is unused... nvbench::copy_kernel<<<256, 256, 0, launch.get_stream()>>>( thrust::raw_pointer_cast(input.data()), thrust::raw_pointer_cast(output.data()), diff --git a/nvbench/detail/measure_cold.cu b/nvbench/detail/measure_cold.cu index 16866a5..3b415fb 100644 --- a/nvbench/detail/measure_cold.cu +++ b/nvbench/detail/measure_cold.cu @@ -43,8 +43,8 @@ measure_cold_base::measure_cold_base(state &exec_state) { if (m_min_samples > 0) { - m_cuda_times.reserve(m_min_samples); - m_cpu_times.reserve(m_min_samples); + m_cuda_times.reserve(static_cast(m_min_samples)); + m_cpu_times.reserve(static_cast(m_min_samples)); } } diff --git a/testing/axes_metadata.cu b/testing/axes_metadata.cu index 039ad18..cf4d93a 100644 --- a/testing/axes_metadata.cu +++ b/testing/axes_metadata.cu @@ -159,7 +159,7 @@ Axis: Other const std::string test = fmt::to_string(buffer); const auto diff = std::mismatch(ref.cbegin(), ref.cend(), test.cbegin(), test.cend()); - const auto idx = diff.second - test.cbegin(); + const auto idx = static_cast(diff.second - test.cbegin()); ASSERT_MSG(test == ref, "Differs at character {}.\n" "Expected:\n\"{}\"\n\n" diff --git a/testing/stdrel_criterion.cu b/testing/stdrel_criterion.cu index 57bdfdd..326196a 100644 --- a/testing/stdrel_criterion.cu +++ b/testing/stdrel_criterion.cu @@ -32,7 +32,7 @@ void test_const() nvbench::detail::stdrel_criterion criterion; criterion.initialize(params); - for (int i = 0; i < 5; i++) + for (int i = 0; i < 5; i++) { // nvbench wants at least 5 to compute the standard deviation criterion.add_measurement(42.0); } @@ -43,7 +43,7 @@ std::vector generate(double mean, double rel_std_dev, int size) { std::random_device rd; std::mt19937 gen(rd()); - std::vector v(size); + std::vector v(static_cast(size)); std::normal_distribution dist(mean, mean * rel_std_dev); std::generate(v.begin(), v.end(), [&]{ return dist(gen); }); return v; @@ -61,7 +61,7 @@ void test_stdrel() nvbench::detail::stdrel_criterion criterion; criterion.initialize(params); - for (nvbench::float64_t measurement: generate(mean, max_noise / 2, size)) + for (nvbench::float64_t measurement: generate(mean, max_noise / 2, size)) { criterion.add_measurement(measurement); } @@ -70,7 +70,7 @@ void test_stdrel() params.set_float64("max-noise", max_noise); criterion.initialize(params); - for (nvbench::float64_t measurement: generate(mean, max_noise * 2, size)) + for (nvbench::float64_t measurement: generate(mean, max_noise * 2, size)) { criterion.add_measurement(measurement); }