NVIDIA/nvbench
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvbench.git synced 2026-07-01 11:47:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

ComparisonThresholds no longer provides constructor with defaults

Browse Source 
Test file changed to use get_default_thresholds() function instead
of call to constructor.

This is to make sure that default preset values do not diverge from
values encoded in the constructor.
This commit is contained in:
Oleksandr Pavlyk
2026-06-25 12:14:04 -05:00
parent 1db6d8bd38
commit d18706cc24
2 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
python/scripts/nvbench_compare.py
View File

@@ -74,14 +74,14 @@ def read_float32_file(filename: str) -> object:
@dataclass(frozen=True)
class ComparisonThresholds:
clear_gap_relative: float = 0.005
same_center_relative: float = 0.005
same_overlap_fraction: float = 0.5
same_relative_dispersion_ceiling: float = 0.02
bulk_same_sample_coverage: float = 0.99
bulk_same_support_coverage: float = 0.80
bulk_support_rare_sample_fraction: float = 0.001
bulk_support_max_removed_sample_fraction: float = 0.01
clear_gap_relative: float
same_center_relative: float
same_overlap_fraction: float
same_relative_dispersion_ceiling: float
bulk_same_sample_coverage: float
bulk_same_support_coverage: float
bulk_support_rare_sample_fraction: float
bulk_support_max_removed_sample_fraction: float
COMPARISON_THRESHOLD_PRESET_VALUES = {