From 02b250f2980b401da114e13aad325b573d34da4a Mon Sep 17 00:00:00 2001
From: Kevin Abraham <kevin.abraham@streamhpc.com>
Date: Fri, 24 Oct 2025 20:11:40 +0000
Subject: [PATCH] implemented tests for instances from
 grouped_convolution_forward_convscale.hpp:210

---
 ..._grouped_convolution_forward_convscale.cpp | 32 +++++++++++++++----
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/experimental/builder/test/test_ck_factory_grouped_convolution_forward_convscale.cpp b/experimental/builder/test/test_ck_factory_grouped_convolution_forward_convscale.cpp
index 997fadada4..51a901d7ed 100644
--- a/experimental/builder/test/test_ck_factory_grouped_convolution_forward_convscale.cpp
+++ b/experimental/builder/test/test_ck_factory_grouped_convolution_forward_convscale.cpp
@@ -19,6 +19,7 @@ using WeiLayout                     = ck::tensor_layout::convolution::GKZYXC;
 using OutLayout                     = ck::tensor_layout::convolution::NDHWGK;
 
 using ck::tensor_operation::device::DeviceGroupedConvFwdMultipleABD;
+using ck::tensor_operation::device::instance::CombConvScale;
 using ck::tensor_operation::device::instance::CombConvScaleRelu;
 using ck::tensor_operation::element_wise::ConvInvscale;
 using ck::tensor_operation::element_wise::ConvScale;
@@ -80,7 +81,7 @@ struct F8_ConvScale
     };
 };
 
-struct F8_comb1_ConvScale
+struct F8_BF8_comb1_ConvScale
 {
     using DeviceOp = ::DeviceOp<ck::Tuple<>,
                                 ck::Tuple<>,
@@ -98,7 +99,7 @@ struct F8_comb1_ConvScale
     };
 };
 
-struct F8_comb2_ConvScale
+struct F8_BF8_comb2_ConvScale
 {
     using DeviceOp = ::DeviceOp<ck::Tuple<>,
                                 ck::Tuple<>,
@@ -116,7 +117,7 @@ struct F8_comb2_ConvScale
     };
 };
 
-struct F8_comb3_ConvScale
+struct F8_BF8_comb3_ConvScale
 {
     using DeviceOp = ::DeviceOp<ck::Tuple<>,
                                 ck::Tuple<>,
@@ -134,6 +135,24 @@ struct F8_comb3_ConvScale
     };
 };
 
+struct F8_float_CombConvScale
+{
+    using DeviceOp = ::DeviceOp<ck::Tuple<>,
+                                ck::Tuple<>,
+                                ck::f8_t,
+                                ck::f8_t,
+                                float,
+                                CombConvScale,
+                                ck::f8_t,
+                                ck::f8_t>;
+
+    constexpr static auto expected = {
+        // clang-format off
+        ""
+        // clang-format on
+    };
+};
+
 struct F8_ConvScaleRelu
 {
     using DeviceOp = ::DeviceOp<ck::Tuple<>,
@@ -201,9 +220,10 @@ struct F8_ConvInvscale
 
 using TestTypes =
     ::testing::Types<F8_ConvScale,
-                                   F8_comb1_ConvScale,
-                                   F8_comb2_ConvScale,
-                                   F8_comb3_ConvScale,
+                                   F8_BF8_comb1_ConvScale,
+                                   F8_BF8_comb2_ConvScale,
+                                   F8_BF8_comb3_ConvScale,
+                                   F8_float_CombConvScale,
                                    F8_ConvScaleRelu,
                                    F8_CombConvScaleRelu,
                                    F8_ConvScaleAdd, F8_ConvInvscale>;