ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-05-04 13:41:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CKTILE] Layout Support for CK Tile engine (#2482)

Browse Source 
* Updating runtime log message for CK TILE ENGINE

* CKTile layout from config

* CKTile custom config for CI

* Documentation for Layout Changes

* CKTile Layout changes  to Jenkins

* Fixing Clang Format

* Changes to Jenkins file to fix error

* fix(cmake-ck-dev): no longer sets invalid values as gpu arch

* style(py files): ruff formatting

* fix(cmake-ck-release): no longer sets invalid values as gpu arch

* chore(cmake-tile_engine): add reminder to uncomment user config json

* Changes to jenkin file to address more cases

* Changes to Jenkins to fix Error

* Changes to Jenkins file for fixing an error

* Update Jenkinsfile (#2517)

* Update Jenkinsfile

---------

Co-authored-by: ThruptiRajLakshmanaGowda <tlakshma@amd.com>
Co-authored-by: AviralGoelAMD <aviral.goel@amd.com>
Co-authored-by: Thomas Ning <Thomas.Ning@amd.com>
This commit is contained in:
Thrupti Raj Lakshmana Gowda
2025-07-17 14:19:41 -05:00
committed by GitHub
parent c08986b026
commit 0f3083ab5c
11 changed files with 239 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
tile_engine/ops/gemm/json_config.py
View File

@@ -118,7 +118,9 @@ class GemmConfig:
trait_config: TraitConfig
@classmethod
def from_json(cls: Type["GemmConfig"], filepath: str, datatype: str) -> "GemmConfig":
def from_json(
cls: Type["GemmConfig"], filepath: str, datatype: str, layout: str
) -> "GemmConfig":
"""JSON configuration loader with validation controls"""
config_path = Path(filepath)
@@ -132,32 +134,40 @@ class GemmConfig:
a_type = datatype
b_type = datatype
c_type = datatype
if b_type == 'int4':
if b_type == "int4":
a_type = "fp16"
if b_type in ['bf8', 'fp8', 'int4']:
if b_type in ["bf8", "fp8", "int4"]:
c_type = "fp16"
layout_parts = layout.lower()
assert len(layout_parts) == 3, (
f"Invalid layout string: {layout} (must be 3 characters like 'rcr' where r stands for row major and c stands for column major)"
)
assert layout_parts[0] in ("r", "c"), (
f"Invalid matrix_a layout: {layout_parts[0]} (must be 'r' for row major or or 'c' for column major)"
)
assert layout_parts[1] in ("r", "c"), (
f"Invalid matrix_a layout: {layout_parts[1]} (must be 'r' for row major or or 'c' for column major)"
)
assert layout_parts[2] == "r", (
f"Invalid matrix_c layout: {layout_parts[2]} (must be 'r' only as currently we are supporting only row major)"
)
a_layout = layout_parts[0]
b_layout = layout_parts[1]
c_layout = layout_parts[2]
# Parse problem config
#TODO: Not reading datatype information from json file.
# TODO: Not reading datatype information from json file.
problem = ProblemConfig(
datatypes=(
EnumConfigParam(
values=[a_type]),
EnumConfigParam(
values=[b_type]),
EnumConfigParam(
values=[c_type])
EnumConfigParam(values=[a_type]),
EnumConfigParam(values=[b_type]),
EnumConfigParam(values=[c_type]),
),
layouts=(
EnumConfigParam(
values=config_dict["problem"]["layout_a"]["values"]
),
EnumConfigParam(
values=config_dict["problem"]["layout_b"]["values"]
),
EnumConfigParam(
values=config_dict["problem"]["layout_c"]["values"]
),
EnumConfigParam(values=[a_layout]),
EnumConfigParam(values=[b_layout]),
EnumConfigParam(values=[c_layout]),
),
)