From 1be9e524ceb1abde4338b18427abc3fa24461afa Mon Sep 17 00:00:00 2001 From: Max Podkorytov <4273004+tenpercent@users.noreply.github.com> Date: Tue, 20 Jan 2026 10:36:10 -0600 Subject: [PATCH] Use unique input values in sequence helper tests - Vary sequence values across all tests to avoid repetition - Use prime numbers for distinct, coprime test data - Add TwoSequences test for unpack_and_merge_sequences --- test/util/unit_sequence_helper.cpp | 52 +++++++++++++++++------------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/test/util/unit_sequence_helper.cpp b/test/util/unit_sequence_helper.cpp index 4f088d262b..2f5894de00 100644 --- a/test/util/unit_sequence_helper.cpp +++ b/test/util/unit_sequence_helper.cpp @@ -45,25 +45,25 @@ TEST(GenerateIdentitySequences, WithNumber) // Test sequence_find_value TEST(SequenceFindValue, FindExistingElement) { - constexpr auto result = sequence_find_value<3>(Sequence<1, 2, 3, 4, 5>{}); - EXPECT_EQ(result, 2); // 3 is at index 2 + constexpr auto result = sequence_find_value<17>(Sequence<5, 11, 17, 23, 29>{}); + EXPECT_EQ(result, 2); // 17 is at index 2 } TEST(SequenceFindValue, FindFirstElement) { - constexpr auto result = sequence_find_value<10>(Sequence<10, 20, 30>{}); + constexpr auto result = sequence_find_value<7>(Sequence<7, 13, 19, 31>{}); EXPECT_EQ(result, 0); } TEST(SequenceFindValue, FindLastElement) { - constexpr auto result = sequence_find_value<30>(Sequence<10, 20, 30>{}); - EXPECT_EQ(result, 2); + constexpr auto result = sequence_find_value<41>(Sequence<3, 11, 23, 41>{}); + EXPECT_EQ(result, 3); } TEST(SequenceFindValue, ElementNotFound) { - constexpr auto result = sequence_find_value<99>(Sequence<1, 2, 3, 4, 5>{}); + constexpr auto result = sequence_find_value<50>(Sequence<2, 8, 14, 26>{}); EXPECT_EQ(result, -1); } @@ -76,8 +76,8 @@ TEST(SequenceFindValue, EmptySequence) // Test find_in_tuple_of_sequences TEST(FindInTupleOfSequences, FindInFirstSequence) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<0, 1>{}, Sequence<2, 3>{}, Sequence<4, 5>{}); - constexpr auto result = find_in_tuple_of_sequences<1>(tuple_of_seqs); + constexpr auto tuple_of_seqs = make_tuple(Sequence<5, 11>{}, Sequence<17, 23>{}, Sequence<29, 37>{}); + constexpr auto result = find_in_tuple_of_sequences<11>(tuple_of_seqs); EXPECT_EQ(result.itran, 0); // Found in first sequence (index 0) EXPECT_EQ(result.idim_up, 1); // At position 1 within that sequence EXPECT_TRUE(result.found); @@ -85,8 +85,8 @@ TEST(FindInTupleOfSequences, FindInFirstSequence) TEST(FindInTupleOfSequences, FindInMiddleSequence) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<0, 1>{}, Sequence<2, 3>{}, Sequence<4, 5>{}); - constexpr auto result = find_in_tuple_of_sequences<3>(tuple_of_seqs); + constexpr auto tuple_of_seqs = make_tuple(Sequence<2, 4, 6>{}, Sequence<8, 10>{}, Sequence<12>{}); + constexpr auto result = find_in_tuple_of_sequences<10>(tuple_of_seqs); EXPECT_EQ(result.itran, 1); // Found in second sequence (index 1) EXPECT_EQ(result.idim_up, 1); // At position 1 within that sequence EXPECT_TRUE(result.found); @@ -94,17 +94,17 @@ TEST(FindInTupleOfSequences, FindInMiddleSequence) TEST(FindInTupleOfSequences, FindInLastSequence) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<0, 1>{}, Sequence<2, 3>{}, Sequence<4, 5>{}); - constexpr auto result = find_in_tuple_of_sequences<5>(tuple_of_seqs); + constexpr auto tuple_of_seqs = make_tuple(Sequence<3>{}, Sequence<7>{}, Sequence<13, 19, 31>{}); + constexpr auto result = find_in_tuple_of_sequences<31>(tuple_of_seqs); EXPECT_EQ(result.itran, 2); // Found in third sequence (index 2) - EXPECT_EQ(result.idim_up, 1); // At position 1 within that sequence + EXPECT_EQ(result.idim_up, 2); // At position 2 within that sequence EXPECT_TRUE(result.found); } TEST(FindInTupleOfSequences, NotFound) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<0, 1>{}, Sequence<2, 3>{}, Sequence<4, 5>{}); - constexpr auto result = find_in_tuple_of_sequences<99>(tuple_of_seqs); + constexpr auto tuple_of_seqs = make_tuple(Sequence<1, 3>{}, Sequence<5, 7, 9>{}); + constexpr auto result = find_in_tuple_of_sequences<100>(tuple_of_seqs); EXPECT_FALSE(result.found); } @@ -117,26 +117,34 @@ TEST(FindInTupleOfSequences, EmptyTuple) TEST(FindInTupleOfSequences, SingleSequence) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<10, 20, 30>{}); - constexpr auto result = find_in_tuple_of_sequences<20>(tuple_of_seqs); + constexpr auto tuple_of_seqs = make_tuple(Sequence<41, 43, 47, 53>{}); + constexpr auto result = find_in_tuple_of_sequences<47>(tuple_of_seqs); EXPECT_EQ(result.itran, 0); - EXPECT_EQ(result.idim_up, 1); + EXPECT_EQ(result.idim_up, 2); EXPECT_TRUE(result.found); } // Test unpack_and_merge_sequences TEST(UnpackAndMergeSequences, MergeMultipleSequences) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<1, 2>{}, Sequence<3, 4>{}, Sequence<5, 6>{}); + constexpr auto tuple_of_seqs = make_tuple(Sequence<7, 11>{}, Sequence<13>{}, Sequence<17, 19, 23>{}); constexpr auto result = unpack_and_merge_sequences(tuple_of_seqs); - using Expected = Sequence<1, 2, 3, 4, 5, 6>; + using Expected = Sequence<7, 11, 13, 17, 19, 23>; EXPECT_TRUE((is_same, Expected>::value)); } TEST(UnpackAndMergeSequences, SingleSequence) { - constexpr auto tuple_of_seqs = make_tuple(Sequence<1, 2, 3>{}); + constexpr auto tuple_of_seqs = make_tuple(Sequence<29, 31, 37, 41>{}); constexpr auto result = unpack_and_merge_sequences(tuple_of_seqs); - using Expected = Sequence<1, 2, 3>; + using Expected = Sequence<29, 31, 37, 41>; + EXPECT_TRUE((is_same, Expected>::value)); +} + +TEST(UnpackAndMergeSequences, TwoSequences) +{ + constexpr auto tuple_of_seqs = make_tuple(Sequence<2, 3, 5>{}, Sequence<7, 11>{}); + constexpr auto result = unpack_and_merge_sequences(tuple_of_seqs); + using Expected = Sequence<2, 3, 5, 7, 11>; EXPECT_TRUE((is_same, Expected>::value)); }